[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility

WordPress Trac noreply at wordpress.org
Sun Nov 13 08:02:37 UTC 2016


#38678: Video Headers: Improve Basic Accessibility
------------------------------------+----------------------------
 Reporter:  davidakennedy           |       Owner:  joemcgill
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Themes                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------

Comment (by bradyvercher):

 @joemcgill Good catch on the JSHint directive. I grabbed `globals` from
 their docs, but it does look like core standardized on `global`. That's
 fixed up in [attachment:38678.7.diff].

 I went ahead and pushed the Vimeo code up to a
 [https://github.com/bradyvercher/custom-header-vimeo new repo here]. There
 are actually a couple of handler variations in that JS file. The active
 one uses their current API, while the other uses their old API, which has
 support for background videos for paid accounts.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list