[wp-trac] [WordPress Trac] #35075: Comment cache ignores custom query vars

WordPress Trac noreply at wordpress.org
Sat Jan 9 16:34:43 UTC 2016


#35075: Comment cache ignores custom query vars
-----------------------------+--------------------------
 Reporter:  jason_the_adams  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Comments         |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:  performance
-----------------------------+--------------------------

Comment (by jason_the_adams):

 Thanks for the direction, @boonebgorges

 Here's what we've got:
 * Since we're using assertNotEquals I'm doing two assertions. Otherwise
 the issue wouldn't reveal itself as the first query would already have
 changed the number of queries
 * I made tests for the other two places -- getPages and getTerms
 * Indentation is now lovelified :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35075#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list