[wp-trac] [WordPress Trac] #35075: Comment cache ignores custom query vars

[WordPress Trac]

#35075: Comment cache ignores custom query vars
-----------------------------+--------------------------
 Reporter:  jason_the_adams  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Comments         |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:  performance
-----------------------------+--------------------------

Comment (by boonebgorges):

 Thanks, @jason_the_adams - The patch looks good. For the test:

 - Don't remove the existing `@ticket` annotation. Just add another one for
 this ticket.
 - Let's change the method name to something that makes more sense. Like:
 `test_comment_cache_key_should_not_ignore_custom_query_vars()`.
 - Can you please fix the indentation? :)
 - Don't bother testing `$start_num + 2`. This makes the test fragile. Just
 `assertNotEquals()`.

 With these changes, please go ahead and work up patches for the other
 places where we do this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35075#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform