[wp-trac] [WordPress Trac] #35075: Comment cache ignores custom query vars

[WordPress Trac]

#35075: Comment cache ignores custom query vars
-----------------------------+--------------------------
 Reporter:  jason_the_adams  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Comments         |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  performance
-----------------------------+--------------------------
Changes (by boonebgorges):

 * keywords:  needs-patch => has-patch


Comment:

 Thanks, @jason_the_adams! [attachment:35075.diff] combines the tests and
 code changes, and makes a few minor modifications.

 I feel like this change is correct - it's better for the cache to be too
 fine-grained than too coarse-grained; in each of these cases, we have
 filters that allow the queries to be modified based on custom parameters,
 but the current caching schema makes them practically impossible to use
 reliably. But I also have a nagging feeling that I'm missing something.
 Could I get another opinion on it, maybe from @dd32 or @nacin ?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35075#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform