[wp-trac] [WordPress Trac] #39152: Twenty Seventeen: phpcs errors and warnings

[WordPress Trac]

#39152: Twenty Seventeen: phpcs errors and warnings
---------------------------+------------------
 Reporter:  dingo_bastard  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.8
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------

Comment (by sstoqnov):

 Hey @davidakennedy, thank you for your comment.
 I have addressed the issues.

 Regarding the `if ( ! function_exists()` call I don't think we should
 remove the indention, just to keep the functions indention low. I mean
 that if the function is written right it will not go very deep.

 I have searched for this check in `twentyseventeen` and all of them were
 fixed.
 However I have remove the indention to keep the code consistent, but I
 will be happy if we add the indention to all themes.
 What do you think, is it ok to do that? And should I open a new ticket or
 can continue here?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39152#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform