[wp-trac] [WordPress Trac] #39152: Twenty Seventeen: phpcs errors and warnings

[WordPress Trac]

#39152: Twenty Seventeen: phpcs errors and warnings
---------------------------+------------------
 Reporter:  dingo_bastard  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.8
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------

Comment (by davidakennedy):

 Hey @sstoqnov! Thanks for the patch – it's looking like a very nice first
 pass. Here are a few items of feedback:

 * In `custom-header.php`, `@param array  $settings Video settings`,
 there's an extra space.
 * In `customizer.php`, the new parameter comments should end in a full
 stop (period).
 * In `content-audio.php`, that file should end in a new line.
 * In `functions.php`, `@param string  $link Link to single post/page`,
 there's an extra space. It must also end in a full stop (period).

 The other larger change I see in a few spots is indenting code after a `if
 ( ! function_exists()` call. You changed it a few spots, but not all of
 them. I realize that it's a code standard to indent after one.
 Historically, I don't think it's been done in some `functions.php` files
 in default themes because it's possible that the indention could get very
 deep. I'd rather be consistent here and not do any of them. Or all of
 them. Personally, I rather just leave them.

 Thanks again for the patch! Looking forward to the next iteration.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39152#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform