[wp-trac] [WordPress Trac] #39152: Twenty Seventeen: phpcs errors and warnings

[WordPress Trac]

#39152: Twenty Seventeen: phpcs errors and warnings
---------------------------+------------------
 Reporter:  dingo_bastard  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.8
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------

Comment (by davidakennedy):

 Thanks for the refreshed patch @sstoqnov! It looks good from a quick
 glance.

 > However I have remove the indention to keep the code consistent, but I
 will be happy if we add the indention to all themes.
 > What do you think, is it ok to do that? And should I open a new ticket
 or can continue here?

 I don't think that's necessary here. I'd opt to just leave everything the
 way it is now. Changing the indention makes sense because it’s a code
 standard, but the difference in readability isn't big enough to bother
 with it here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39152#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform