[wp-trac] [WordPress Trac] #32464: Menu args and 'container' => 'false'

[WordPress Trac]

#32464: Menu args and  'container' => 'false'
-----------------------------------+-----------------------------
 Reporter:  ChiefAlchemist         |       Owner:  wonderboymusic
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  4.4
Component:  Menus                  |     Version:  4.2
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |     Focuses:  docs
-----------------------------------+-----------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"34630"]:
 {{{
 #!CommitTicketReference repository="" revision="34630"
 Nav Menus: in `wp_nav_menu()`, `$container` is already bound to a list of
 allowed tags. PHP, being its whimsical self, while return `true` if
 someone sets `$container` to `true` via `in_array( true, [ 'div', 'nav' ]
 )`. Check that `$container` is a string before the `in_array()` check.
 `'true'` does not pass.

 Props shedonist for the original patch.
 Fixes #32464.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32464#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform