[wp-trac] [WordPress Trac] #32464: Menu args and 'container' => 'false'

[WordPress Trac]

#32464: Menu args and  'container' => 'false'
-----------------------------------+-------------------
 Reporter:  ChiefAlchemist         |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  4.4
Component:  Menus                  |     Version:  4.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  docs
-----------------------------------+-------------------

Comment (by ChiefAlchemist):

 1) This says the container is removable, yes?

 http://codex.wordpress.org/Function_Reference/wp_nav_menu#Removing_the_Navigation_Container

 2) If false is legit most would presume true would be as well. As in there
 could be conditions where you'd want 'container' => $bool_flag - where
 $bool_flag is set programatically.

 3) Moi? I was always trained to presume the worst, including "developer
 error" (even when it doesn't make sense.) That is, in this case, the
 function should validate / catch the "error" (just in case) and not
 presume the dev will be inhuman (i.e., perfect.)

 Documented or not, the result is not desired and/or the function could be
 more robust. Again, maybe it's just me, but to me leaving it as-is doesn't
 make sense. Up to you :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32464#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform