[wp-trac] [WordPress Trac] #32464: Menu args and 'container' => 'false'

[WordPress Trac]

#32464: Menu args and  'container' => 'false'
-----------------------------------+-----------------------------
 Reporter:  ChiefAlchemist         |       Owner:  wonderboymusic
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  4.4
Component:  Menus                  |     Version:  4.2
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |     Focuses:  docs
-----------------------------------+-----------------------------

Comment (by shedonist):

 Scott, I see that your fix addresses the problem in a different way which
 does resolve the issue. However your fix results in 'container' = true not
 returning a container at all whereas my fix results in the default "div"
 container being returned. Wouldn't it be better to return a container
 since the true argument implies one was desired? Or is it considered
 better to make the function conform to the function documentation?

 I'm not trying to be argumentative. I'm just genuinely curious as this is
 my first foray into contributing to core and I'd like to better understand
 the preferred methodology. Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32464#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform