[wp-trac] [WordPress Trac] #33311: TB_window spinner should probably disappear when loading is done

[WordPress Trac]

#33311: TB_window spinner should probably disappear when loading is done
-------------------------+-------------------------------------------------
 Reporter:  niklasbr     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Plugins      |     Version:  4.2.4
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, javascript, administration,
  dev-feedback           |  performance
-------------------------+-------------------------------------------------

Comment (by niklasbr):

 Thanks. I'll give it another try to submit a better patch, but before that
 maybe we can try to agree whether or not we should use the {{{.spinner}}}
 class on the modal or some new CSS rule?

 My own reason for choosing it is that it looked to me to be the solution
 with the least code changes needed. As you can see the patch have more
 deletions than insertions. The {{{.spinner}}} class is already using the
 same graphics as previously, which to me indicates that the {{{.spinner}}}
 class serves a mostly identical semantic purpose as the {{{spinner.gif}}}
 background in the modal.

 A related question which occurred to me is whether or not this issue could
 be expanded to increase the accessibility of the modal by adding ARIA
 attributes and making sure it has proper focus?

 By the way, I can't access the Slack channel you link to, maybe because I
 am not a contributor?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33311#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform