[wp-trac] [WordPress Trac] #33311: TB_window spinner should probably disappear when loading is done

[WordPress Trac]

#33311: TB_window spinner should probably disappear when loading is done
-------------------------+-------------------------------------------------
 Reporter:  niklasbr     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Plugins      |     Version:  4.2.4
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, javascript, administration,
  dev-feedback           |  performance
-------------------------+-------------------------------------------------

Comment (by afercia):

 Yes the file name format should be ticket#.patch, there are exceptions for
 example when creating alternate versions etc. Generally, patches should be
 built from the SVN install root, so that the paths in the patch would
 start with `src/...`. This way, people who want to manually download and
 apply a patch could easily do that on all platforms and using different
 tools.
 By the way, [https://wordpress.slack.com/archives/core/p1441144476002124
 I've asked on Slack] and when applying patches the Grunt `patch` task
 should handle the Git diffs too. See
 https://make.wordpress.org/core/handbook/testing/patch/

 About the patch itself:
 - not sure we can simply use the existing ".spinner" rule since it uses
 some properties that should be reset for the modal (e.g. float,
 opacity...)
 - also, not sure the CSS class name "spinner" would be appropriate,
 because that’s not what we really use it for so maybe it would be more
 appropriate to be `loading` or something like that

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33311#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform