[wp-trac] [WordPress Trac] #28979: Customizer panels should have the same priority hierarchy as Sections

WordPress Trac noreply at wordpress.org
Tue Aug 12 05:42:21 UTC 2014


#28979: Customizer panels should have the same priority hierarchy as Sections
--------------------------+-----------------------
 Reporter:  mattwiebe     |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  4.0
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui
--------------------------+-----------------------
Changes (by celloexpressions):

 * keywords:  has-patch => needs-patch


Comment:

 We need to tweak the colors more; didn't realize you left the focus/active
 change out of the commit. I think that that part of the patch is very
 necessary, but if we don't do it, the darker color of the two-tone (and
 the corresponding border colors) needs to be lighter on both normal and
 (especially) focus/hover states.

 But the bigger problem is that the focus/hover/open/active color for
 sections (I think `#eee` is really the only option given the current
 design) matches the off-white color from the two-toned panels (for which
 `#f5f5f5` works, unless we don't change the other color, in which case we
 need to make it even lighter). The whole point here is for them to be
 different; they start to run together when you actually play around with
 it without the rest of the patch there. So we need to either lighten the
 offset color even more, or, do what's in [attachment:28979.design.diff],
 or something more extreme (but we already tried a bunch of variants of
 that).

 Not sure if only committing part of the patch was intentional, but there
 are some places where color changes but not background color changes were
 made, etc. so something odd happened there.


 ----


 Also re: why we really should make the more fundamental changes along with
 mixed sorting, `WP_Customize_Panel::panels` is a thing...

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28979#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list