[wp-trac] [WordPress Trac] #28979: Customizer panels should have the same priority hierarchy as Sections

WordPress Trac noreply at wordpress.org
Tue Aug 12 17:00:52 UTC 2014


#28979: Customizer panels should have the same priority hierarchy as Sections
-------------------------------------+-----------------------
 Reporter:  mattwiebe                |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  high                     |   Milestone:  4.0
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui
-------------------------------------+-----------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 I feel pretty good about [attachment:28979.2.diff] / [attachment:28979.2
 .class-wp-customize-section.diff]. As I said before, it's pretty involved.
 But if containers are going to be a thing, they should be an actual thing.
 Panels are not sections, sections and panels are both containers; since
 we're mixing sorting this distinction needs to be clear internally. This
 needs thorough review from westonruter, etc.

 The only residual awkwardness that this leaves is the
 `customize_render_section` actions, but we can't really change those. Will
 need extensive testing because the Customizer (CSS especially) was not
 designed with nested accordion sections (need to probably add some more
 `>`s).

 Re: design it still feels really wrong, but `#eee` (matching header/footer
 actions) seems to work the best without changing things around completely.
 We should probably lighten the offset panel-arrow background hover-state
 even with this change, as it's a bit too contrasty with everything else.
 `#fff` to `#f5f5f5` is 10 shades for the contrast in the standard state,
 we should use `#e5e5e5` instead of `#ddd` for the background and then
 change the borders to `#ddd` for the hover/focus state to match (since
 that'll be against `#eee`).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28979#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list