[wp-trac] [WordPress Trac] #28979: Customizer panels should have the same priority hierarchy as Sections

WordPress Trac noreply at wordpress.org
Tue Aug 12 04:02:13 UTC 2014


#28979: Customizer panels should have the same priority hierarchy as Sections
--------------------------+-----------------------
 Reporter:  mattwiebe     |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  4.0
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui
--------------------------+-----------------------

Comment (by celloexpressions):

 [attachment:28979.diff] is a good start, but I think we should definitely
 change how the subclassing works - making both `WP_Customize_Section` and
 `WP_Customize_Panel` extend `WP_Customize_Container`. That clarifies the
 purpose of each class and is something we had considered doing anyway -
 but got lost in the shuffle (@westonruter suggested initially in June).
 Otherwise, for example, we have things like
 `WP_Customize_Panel::controls`, which even though they aren't used seems
 wrong. I can put that together pretty quickly tomorrow morning. I do think
 that our UI changes resolve many of my concerns with mixed sorting.

 In terms of sorting, I think that Widgets would make the most sense being
 before Static Front page, after header & background image, as that's one
 option that's very rarely going to change and is independent of many
 preview contexts (we should make it contextual once we have contextual
 sections), whereas Widgets are likely to be used/changed more frequently
 and are directly related to the preview. Generally speaking, I like the
 order in [attachment:customize-panels-two-tone-mixed.png​] if those
 sections & panels were to exist on a given site based on the plugins &
 theme (that's Twenty Eleven) being used. Switching the default priority to
 be at the bottom (proposed 160 in #29172) would mean that there would
 often be a section after static front page (pending the particular set of
 plugins/theme), but by default it would just be static front page after
 Widgets. So it may be better to put widgets at 140 until we have another
 core panel, but my preference would be at 110 (before static front page).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28979#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list