[wp-trac] [WordPress Trac] #20074: Attempt MD5 checksum verification in upgrader if available
WordPress Trac
wp-trac at lists.automattic.com
Sun Feb 19 06:22:28 UTC 2012
#20074: Attempt MD5 checksum verification in upgrader if available
------------------------------------+------------------
Reporter: sivel | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.4
Component: Upgrade/Install | Version: 2.8
Severity: normal | Resolution:
Keywords: has-patch dev-feedback |
------------------------------------+------------------
Comment (by nacin):
> An alternative that could be used here, would be to perform the md5
check within the download function if the header exists, and return a
WP_Error instead if it doesn't match. But that's assuming that the md5
headers can be trusted from non-wp sources as well.
An alternative implementation could be `download_url( $url, $timeout =
300, &$response = null )`, and then we simply assign the response to
$response, therefore optionally being able to pass that back as well.
That's basically what sivel's patch does, though this would probably be a
bit cleaner.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20074#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list