[wp-trac] [WordPress Trac] #20074: Attempt MD5 checksum verification in upgrader if available

[WordPress Trac]

#20074: Attempt MD5 checksum verification in upgrader if available
------------------------------------+------------------
 Reporter:  sivel                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  3.4
Component:  Upgrade/Install         |     Version:  2.8
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by dd32):

 Just to be clear: The MD5 verification that was talked about in the past
 was individual file md5 checks to ensure that the local files were correct
 before performing a partial build upgrade.

 An alternative that could be used here, would be to perform the md5 check
 within the download function if the header exists, and return a WP_Error
 instead if it doesn't match. But that's assuming that the md5 headers can
 be trusted from non-wp sources as well.

 This would simply catch a incomplete download earlier, with a better
 message, a corrupt or incomplete zip download will currently throw a
 'archive in an incompatible format' type error (since the zip verification
 fails) - which is a good thing, a more specific error is nice in this case
 and lets users know what's up without a potentially cryptic error

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20074#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software