[theme-reviewers] Use of sass in wordpress theme

[priyanshu mittal]

Thanks all
Close this thread

On Wed, Oct 15, 2014 at 10:16 PM, Emil Uzelac <emil at uzelac.me> wrote:

> Now that I am on desktop:
>
> Theme uses:
>
> wp_enqueue_style( 'anchorage-sass',
> get_template_directory_uri().'/sass/output.css' , array(), '2014-05-30' );
>
> Great, but not for us.
>
> Here's what guideline says:
>
> he default stylesheet must be referenced via get_stylesheet_uri()
>
> Noted in:
> https://make.wordpress.org/themes/handbook/guidelines/including-stylesheets-scripts/
>
> But for the record he did start good:
>
> // wp_enqueue_style( 'anchorage-style', get_stylesheet_uri(), array(),
> '2014-05-30' );
>
> If that was not commented ;)
>
> On Wed, Oct 15, 2014 at 10:38 AM, Otto <otto at ottodestruct.com> wrote:
>
>> Also, in a child-theme situation, get_stylesheet_uri() will return the
>> child theme's style.css. I would say that this means it is required for
>> proper child theme support.
>>
>>
>> -Otto
>>
>> On Wed, Oct 15, 2014 at 10:02 AM, Justin Tadlock <
>> justin at justintadlock.com> wrote:
>>
>>> It should be unacceptable to not use `get_stylesheet_uri()`.  The output
>>> of this function can be filtered if the theme author doesn't want to load
>>> the `style.css` file.  The theme should be filtering `stylesheet_uri` and
>>> replacing it with the stylesheet they wish to load.
>>>
>>> The reason we want theme authors to use specific functions to do
>>> specific things is not simply because WordPress makes these functions
>>> available.  That's not a good enough reason.  The reason we do this is
>>> because these functions have hooks associated with them that plugin authors
>>> (or child theme authors) should expect to be available.
>>>
>>> Anyway, I'd say this falls under "Themes are required to implement
>>> WordPress template tags and hooks properly."
>>> http://codex.wordpress.org/Theme_Review#Template_Tags_and_Hooks:
>>>
>>> On Wed, Oct 15, 2014 at 8:31 AM, Emil Uzelac <emil at uzelac.me> wrote:
>>>
>>>> From what I can see (quick scan from my phone) is that author is adding
>>>> CSS from different source. But yes, it's acceptable.
>>>>
>>>>
>>>> On Wednesday, October 15, 2014, priyanshu mittal <
>>>> priyanshu.mittal at gmail.com> wrote:
>>>>
>>>>> But what about the style.css file, I mean developer din't used get_stylesheet_uri
>>>>> in the theme. Is this fine?
>>>>>
>>>>> On Wed, Oct 15, 2014 at 6:49 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>>>
>>>>>> SASS is perfectly fine and acceptable.
>>>>>>
>>>>>>
>>>>>> On Wednesday, October 15, 2014, priyanshu mittal <
>>>>>> priyanshu.mittal at gmail.com> wrote:
>>>>>>
>>>>>>> Hi ,
>>>>>>>
>>>>>>> I am reviewing a theme in which user have used sass techinique. I
>>>>>>> would like to know  the proper use of this in themes.
>>>>>>>
>>>>>>> I have deleted the style.css file but that dint make any difference.
>>>>>>>
>>>>>>> Kindly guide me on this
>>>>>>>
>>>>>>> Tickert url: https://themes.trac.wordpress.org/ticket/20574
>>>>>>>
>>>>>>> Thanks
>>>>>>> Priyanshu
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141015/48f25eb8/attachment-0001.html>