<div dir="ltr">Thanks all <div>Close this thread</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 15, 2014 at 10:16 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Now that I am on desktop:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Theme uses: </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(0,0,0);white-space:pre-wrap;font-family:arial"><br></span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(0,0,0);white-space:pre-wrap;font-family:arial">wp_enqueue_style( 'anchorage-sass', get_template_directory_uri().'/sass/output.css' , array(), '2014-05-30' );</span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(0,0,0);white-space:pre-wrap;font-family:arial"><br></span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(0,0,0);white-space:pre-wrap;font-family:arial">Great, but not for us.</span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(0,0,0);white-space:pre-wrap;font-family:arial"><br></span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(0,0,0);white-space:pre-wrap;font-family:arial">Here's what guideline says:</span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="color:rgb(0,0,0);white-space:pre-wrap;font-family:arial"><br></span></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap">he default stylesheet must be referenced via get_stylesheet_uri()</span></font><br></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap"><br></span></font></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap">Noted in: <a href="https://make.wordpress.org/themes/handbook/guidelines/including-stylesheets-scripts/" target="_blank">https://make.wordpress.org/themes/handbook/guidelines/including-stylesheets-scripts/</a></span><br></font></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap"><br></span></font></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap">But for the record he did start good:</span></font></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap"><br></span></font></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap">// wp_enqueue_style( 'anchorage-style', get_stylesheet_uri(), array(), '2014-05-30' );</span><br></font></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap"><br></span></font></div><div class="gmail_default"><font color="#000000"><span style="white-space:pre-wrap">If that was not commented ;)</span></font></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 15, 2014 at 10:38 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Also, in a child-theme situation, <span style="font-family:arial,sans-serif;font-size:13px">get_stylesheet_uri() will return the child theme's style.css. I would say that this means it is required for proper child theme support.</span><span><font color="#888888"><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div></font></span></div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div>-Otto</div></font></span><div><div>
<br><div class="gmail_quote">On Wed, Oct 15, 2014 at 10:02 AM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>It should be unacceptable to not use `get_stylesheet_uri()`.  The output of this function can be filtered if the theme author doesn't want to load the `style.css` file.  The theme should be filtering `stylesheet_uri` and replacing it with the stylesheet they wish to load.</div><div><br></div><div>The reason we want theme authors to use specific functions to do specific things is not simply because WordPress makes these functions available.  That's not a good enough reason.  The reason we do this is because these functions have hooks associated with them that plugin authors (or child theme authors) should expect to be available.</div><div><br></div><div>Anyway, I'd say this falls under "Themes are required to implement WordPress template tags and hooks properly."</div><div><a href="http://codex.wordpress.org/Theme_Review#Template_Tags_and_Hooks" target="_blank">http://codex.wordpress.org/Theme_Review#Template_Tags_and_Hooks</a>:</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 15, 2014 at 8:31 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@uzelac.me" target="_blank">emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From what I can see (quick scan from my phone) is that author is adding CSS from different source. But yes, it's acceptable.<div><div><span></span><br><br>On Wednesday, October 15, 2014, priyanshu mittal <<a href="mailto:priyanshu.mittal@gmail.com" target="_blank">priyanshu.mittal@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">But what about the style.css file, I mean developer din't used <span style="color:rgb(0,0,0);white-space:pre-wrap">get_stylesheet_uri in the theme. Is this fine?</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 15, 2014 at 6:49 PM, Emil Uzelac <span dir="ltr"><<a>emil@uzelac.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">SASS is perfectly fine and acceptable.<div><div><span></span><br><br>On Wednesday, October 15, 2014, priyanshu mittal <<a>priyanshu.mittal@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi ,<div><br></div><div>I am reviewing a theme in which user have used sass techinique. I would like to know  the proper use of this in themes.</div><div><br></div><div>I have deleted the style.css file but that dint make any difference.</div><div><br></div><div>Kindly guide me on this</div><div><br></div><div>Tickert url: <a href="https://themes.trac.wordpress.org/ticket/20574" target="_blank">https://themes.trac.wordpress.org/ticket/20574</a></div><div><br></div><div>Thanks</div><div>Priyanshu</div><div><br></div><div><br></div></div>
</blockquote>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a>theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</blockquote>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>