[theme-reviewers] Bundled plugins

Chip Bennett chip at chipbennett.net
Sat Jan 25 15:45:43 UTC 2014


No, Themes should not ever be installing anything automatically. Themes
must be entirely self-contained.


On Sat, Jan 25, 2014 at 10:42 AM, emin ozlem <eminozlem at gmail.com> wrote:

> When you say bundle, are themes allowed only to ship plugins with them to
> be installed manually , or are they allowed to install them automatically
> too upon theme activation ?
>
>
> 2014-01-25 Bass Jobsen <bass at w3masters.nl>
>
>  Hello,
>>
>> I found some themes who advertise to be "retina ready". Recently i
>> dropped retina support from my theme in favor to a plugin (
>> http://wordpress.org/plugins/wp-retina-2x/ ). If you don't use a plugin
>> in this case, theme reviewers should still have to evaluate the built in
>> retina support code.
>> Evaluation this code should be as difficult or easy as reviewing plugin
>> code will be.
>> Guidelines don't tell you now  what functions should build in or not.
>>
>> Regards, Bass
>>
>>
>> 2014/1/24 Jose Castaneda <jomcastaneda at gmail.com>
>>
>>> I totally agree with that. Main reason I chose to say case by case. :)
>>>
>>> Sent from my iPhone
>>>
>>> On Jan 24, 2014, at 11:40 AM, Justin Tadlock <justin at justintadlock.com>
>>> wrote:
>>>
>>>  I agree that themes should not bundle plugins and would like to see a
>>> guideline on this subject.  However, I do want to note that this is not
>>> always a black-and-white thing.  Personally, I bundle several scripts with
>>> my themes.  These are scripts written specifically for use in themes.  I
>>> just also happen to have released them as standalone plugins for others to
>>> use.  These plugins usually require users to enter code into their theme.
>>> Basically, I just want reviewers to keep this in mind.
>>>
>>> Ultimately, what we're looking at is whether something belongs within
>>> the theme, which means it should be related to the presentation of the
>>> site.  I believe our guidelines already cover this perfectly fine.
>>> Formalizing a guideline on not bundling plugins will only serve to better
>>> clarify what we already have in place.
>>>
>>> On 1/24/2014 1:21 PM, Emil Uzelac wrote:
>>>
>>> I have zero issues with that, but we should add few lines in our
>>> guidelines :-)
>>> On Jan 24, 2014 12:12 PM, "Chip Bennett" <chip at chipbennett.net> wrote:
>>>
>>>> Regardless of the Guidelines' stance on bundled Plugins, reviews should
>>>> *always* be conducted without any recommended Plugins.
>>>>
>>>>
>>>> On Fri, Jan 24, 2014 at 1:08 PM, Josh Pollock <jpollock412 at gmail.com>wrote:
>>>>
>>>>> +1 to Chip on making this a formal part of the guidelines.
>>>>>
>>>>>  I think the guidelines should specify if the review will be
>>>>> conducted with and without any recommended plugins activated or just
>>>>> without.
>>>>>
>>>>>
>>>>> On Fri, Jan 24, 2014 at 12:16 PM, Jose Castaneda <
>>>>> jomcastaneda at gmail.com> wrote:
>>>>>
>>>>>>  I, too, feel it can be a requirement that themes not bundle it.
>>>>>>
>>>>>>  It not only takes up storage within the theme's folder but can,
>>>>>> and, may differ from one in the repo. Who's to say they don't do a bait and
>>>>>> switch.
>>>>>>
>>>>>>  From what I recall from wptavern's post about the plugin repo they
>>>>>> are able to approve a plugin fairly quickly. The biggest reason for not
>>>>>> getting approved is because the developer doesn't respond/fix the issues.
>>>>>>
>>>>>>  Sent from my iPhone
>>>>>>
>>>>>> On Jan 24, 2014, at 8:37 AM, Chip Bennett <chip at chipbennett.net>
>>>>>> wrote:
>>>>>>
>>>>>>   ...which explains why bundled Plugins should not be allowed. Theme
>>>>>> reviewers cannot reasonably be expected to review Plugin code.
>>>>>>
>>>>>>  We've been discussing it for a while now. Unless there remains some
>>>>>> reasonable opposition, I would like to formalize it, and require that
>>>>>> Themes not bundle Plugins.
>>>>>>
>>>>>>
>>>>>> On Fri, Jan 24, 2014 at 11:30 AM, Christine Rondeau <
>>>>>> christine at bluelimemedia.com> wrote:
>>>>>>
>>>>>>> Oh, oh.. I wasn't aware of that. I reviewed the theme, didn't see
>>>>>>> anything wrong and so marked it as approved. I didn't even think to review
>>>>>>> the plugins, but I don't think that I could anyway. Plugins fall in a total
>>>>>>> different category.
>>>>>>>
>>>>>>>  I also work for cyberchimps. I do customer support for them and I
>>>>>>> have a few themes in the repo under my name.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Christine Rondeau
>>>>>>> Bluelime Media
>>>>>>> www.bluelimemedia.com
>>>>>>> twitter: @bluelimemedia
>>>>>>> skype: bluelimemedia
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>   On Fri, Jan 24, 2014 at 3:31 AM, Srikanth Koneru <tskk79 at gmail.com
>>>>>>> > wrote:
>>>>>>>
>>>>>>>>  In recent discussion, its recommended not to bundle the plugin,
>>>>>>>> if its bundled then it has to be reviewed too.
>>>>>>>>  you work for cyberchimps too?
>>>>>>>>
>>>>>>>>
>>>>>>>>  On Fri, Jan 24, 2014 at 12:53 PM, Emil Uzelac <emil at uzelac.me>wrote:
>>>>>>>>
>>>>>>>>> Please don't beat yourself up, we have so many questions and
>>>>>>>>> discussions going on and it ain't easy to keep up with all of them :-)
>>>>>>>>>  On Jan 24, 2014 1:14 AM, "Christine Rondeau" <
>>>>>>>>> christine at bluelimemedia.com> wrote:
>>>>>>>>>
>>>>>>>>>> Ok good to know. I must have misread or thought I read about
>>>>>>>>>> plugins not being allowed as part of the theme. I try to keep up with the
>>>>>>>>>> list, but there's a bit too much sometimes . :)
>>>>>>>>>>
>>>>>>>>>>  I'll approve the theme then, since I think the rest is ok.
>>>>>>>>>>
>>>>>>>>>>  Cheers
>>>>>>>>>>
>>>>>>>>>> Christine Rondeau
>>>>>>>>>> Bluelime Media
>>>>>>>>>> www.bluelimemedia.com
>>>>>>>>>> twitter: @bluelimemedia
>>>>>>>>>> skype: bluelimemedia
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Jan 23, 2014 at 11:10 PM, Emil Uzelac <emil at uzelac.me>wrote:
>>>>>>>>>>
>>>>>>>>>>> We don't have any special guidelines about plugin being part of
>>>>>>>>>>> the Theme. It's recommended, but no it is not required. Many authors do :-)
>>>>>>>>>>>  On Jan 24, 2014 1:00 AM, "Christine Rondeau" <
>>>>>>>>>>> christine at bluelimemedia.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>>  Just want to double check again, but I seem to recall that
>>>>>>>>>>>> plugins CANNOT be bundled with themes.
>>>>>>>>>>>>
>>>>>>>>>>>>  I'm reviewing a theme right now -
>>>>>>>>>>>> https://themes.trac.wordpress.org/ticket/16203#comment:4
>>>>>>>>>>>> and the theme works without the plugin and installing the
>>>>>>>>>>>> plugins is optional, but if you choose to install these, they are
>>>>>>>>>>>> downloaded directly from the theme.
>>>>>>>>>>>>
>>>>>>>>>>>>  I'm pretty sure that this is not allowed right?
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>  Christine
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>  _______________________________________________
>>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> theme-reviewers mailing list
>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing list
>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>>
>>>>>>   _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing listtheme-reviewers at lists.wordpress.orghttp://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20140125/5e74c0b1/attachment-0001.html>


More information about the theme-reviewers mailing list