[theme-reviewers] Theme update failed

Tue Aug 6 18:19:32 UTC 2013

I would tend to agree with Otto ... adding in the myriad amount of
frameworks that allow for `body_class` to not be written in the `<body>`
tag would be a slippery slope to start down.
There must be other alternatives, perhaps along the lines Justin is
referring to?

Edward Caissie
aka Cais.

On Tue, Aug 6, 2013 at 2:17 PM, Justin Tadlock <justin at justintadlock.com>wrote:

> Could we not check for 'body_class' only in the same way as 'post_class'?
>  I'd have to look through the code more, but that should work.
>
>
> On 8/6/2013 1:13 PM, Otto wrote:
>
>> On Tue, Aug 6, 2013 at 12:47 PM, Chip Bennett <chip at chipbennett.net>
>> wrote:
>>
>>> That is the fast-track to not-approval. Please don't do that.
>>>
>>> If the hybrid core function properly outputs the filtered core
>>> body_class()
>>> output, then it is fine. If a custom uploader/Theme Check test needs to
>>> be
>>> added to account for it, let's let Otto weigh in on that.
>>>
>>> (Backward compatibility probably should have been added the other way,
>>> but
>>> we're long past that point now.)
>>>
>> Right now, it's looking for this:
>>
>> <body.*body_class\(
>>
>> We could change that to something like this:
>>
>> <body.*(body_class|hybrid_**body_attributes)\(
>>
>> But I dislike the idea of putting framework specific code into Theme
>> Check. I would prefer an alternative approach.
>>
>> Suggestions?
>>
>> -Otto
>> ______________________________**_________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
>> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>>
>
> ______________________________**_________________
> theme-reviewers mailing list
> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130806/292bfa90/attachment.html>