<div dir="ltr">I would tend to agree with Otto ... adding in the myriad amount of
frameworks that allow for `body_class` to not be written in the
`<body>` tag would be a slippery slope to start down.<br>There must be other alternatives, perhaps along the lines Justin is referring to?<br></div><div class="gmail_extra"><br clear="all"><div>Edward Caissie<br>aka Cais.</div>
<br><br><div class="gmail_quote">On Tue, Aug 6, 2013 at 2:17 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Could we not check for 'body_class' only in the same way as 'post_class'? I'd have to look through the code more, but that should work.<div class="HOEnZb"><div class="h5"><br>
<br>
On 8/6/2013 1:13 PM, Otto wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Tue, Aug 6, 2013 at 12:47 PM, Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
That is the fast-track to not-approval. Please don't do that.<br>
<br>
If the hybrid core function properly outputs the filtered core body_class()<br>
output, then it is fine. If a custom uploader/Theme Check test needs to be<br>
added to account for it, let's let Otto weigh in on that.<br>
<br>
(Backward compatibility probably should have been added the other way, but<br>
we're long past that point now.)<br>
</blockquote>
Right now, it's looking for this:<br>
<br>
<body.*body_class\(<br>
<br>
We could change that to something like this:<br>
<br>
<body.*(body_class|hybrid_<u></u>body_attributes)\(<br>
<br>
But I dislike the idea of putting framework specific code into Theme<br>
Check. I would prefer an alternative approach.<br>
<br>
Suggestions?<br>
<br>
-Otto<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</blockquote>
<br>
______________________________<u></u>_________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.<u></u>wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/<u></u>mailman/listinfo/theme-<u></u>reviewers</a><br>
</div></div></blockquote></div><br></div>