[theme-reviewers] Theme update failed

Justin Tadlock justin at justintadlock.com
Tue Aug 6 18:17:06 UTC 2013

Could we not check for 'body_class' only in the same way as 
'post_class'?  I'd have to look through the code more, but that should work.

On 8/6/2013 1:13 PM, Otto wrote:
> On Tue, Aug 6, 2013 at 12:47 PM, Chip Bennett <chip at chipbennett.net> wrote:
>> That is the fast-track to not-approval. Please don't do that.
>> If the hybrid core function properly outputs the filtered core body_class()
>> output, then it is fine. If a custom uploader/Theme Check test needs to be
>> added to account for it, let's let Otto weigh in on that.
>> (Backward compatibility probably should have been added the other way, but
>> we're long past that point now.)
> Right now, it's looking for this:
> <body.*body_class\(
> We could change that to something like this:
> <body.*(body_class|hybrid_body_attributes)\(
> But I dislike the idea of putting framework specific code into Theme
> Check. I would prefer an alternative approach.
> Suggestions?
> -Otto
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers

More information about the theme-reviewers mailing list