[theme-reviewers] Theme update failed

Otto otto at ottodestruct.com
Tue Aug 6 18:13:53 UTC 2013


On Tue, Aug 6, 2013 at 12:47 PM, Chip Bennett <chip at chipbennett.net> wrote:
> That is the fast-track to not-approval. Please don't do that.
>
> If the hybrid core function properly outputs the filtered core body_class()
> output, then it is fine. If a custom uploader/Theme Check test needs to be
> added to account for it, let's let Otto weigh in on that.
>
> (Backward compatibility probably should have been added the other way, but
> we're long past that point now.)

Right now, it's looking for this:

<body.*body_class\(

We could change that to something like this:

<body.*(body_class|hybrid_body_attributes)\(

But I dislike the idea of putting framework specific code into Theme
Check. I would prefer an alternative approach.

Suggestions?

-Otto


More information about the theme-reviewers mailing list