[theme-reviewers] Ticket recheck by Admin
georgemamadashvili at gmail.com
Mon Mar 12 19:18:17 UTC 2012
Thanks Chip for recheck.
We had a similar conversation few month ago and I totally agree with you.
Is there anything I missed while reviewing the theme?
On Mon, Mar 12, 2012 at 11:05 PM, Chip Bennett <chip at chipbennett.net> wrote:
> I think it is sound to require all Themes to use their own public
> namespace. Obviously, a Child Theme would by necessity use the Parent
> Theme's namespace where appropriate. But in these cases, we're talking
> about derivative - i.e. forked - Themes.
> We currently require derivatives of Twenty Ten/Twenty Twelve to use their
> own namespace for function names, hooks, etc. I see no reason to treat
> Underscores derivatives any differently.
> Anyone else have thoughts?
> On Mon, Mar 12, 2012 at 1:54 PM, George Mamadashvili <
> georgemamadashvili at gmail.com> wrote:
>> Sorry, my bad.
>> Chip this theme has same issue as Toolbox 1.4 ( I asked about that
>> early), not-prefixed actions and more other Automattic themes will have,
>> cause they're based on _s theme. Pulled request on github to fix that, but
>> theme wranglers have different opinion about that. Should I point that
>> anyway? Here's GitHub issue URL -
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers