Thanks Chip for recheck.<div><br></div><div>We had a similar conversation few month ago and I totally agree with you.</div><div><br></div><div>Is there anything I missed while reviewing the theme?<br><br><div class="gmail_quote">
On Mon, Mar 12, 2012 at 11:05 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I think it is sound to require all Themes to use their own public namespace. Obviously, a Child Theme would by necessity use the Parent Theme's namespace where appropriate. But in these cases, we're talking about derivative - i.e. forked - Themes.<div>
<br></div><div>We currently require derivatives of Twenty Ten/Twenty Twelve to use their own namespace for function names, hooks, etc. I see no reason to treat Underscores derivatives any differently.</div><div><br></div>
<div>Anyone else have thoughts?</div><span class="HOEnZb"><font color="#888888"><div><br></div></font></span><div><span class="HOEnZb"><font color="#888888">Chip<br><br></font></span><div class="gmail_quote"><div><div class="h5">
On Mon, Mar 12, 2012 at 1:54 PM, George Mamadashvili <span dir="ltr"><<a href="mailto:georgemamadashvili@gmail.com" target="_blank">georgemamadashvili@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">Sorry, my bad.<div><br></div><div><a href="http://themes.trac.wordpress.org/ticket/6833" target="_blank">http://themes.trac.wordpress.org/ticket/6833</a><br>
</div><div><br></div><div>Chip this theme has same issue as Toolbox 1.4 ( I asked about that early), not-prefixed actions and more other Automattic themes will have, cause they're based on _s theme. Pulled request on github to fix that, but theme wranglers have different opinion about that. Should I point that anyway? Here's GitHub issue URL - <a href="https://github.com/Automattic/_s/pull/6#issuecomment-4458047" target="_blank">https://github.com/Automattic/_s/pull/6#issuecomment-4458047</a></div>
<br></div></div><div class="im">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>