[theme-reviewers] Ticket recheck by Admin
Chip Bennett
chip at chipbennett.net
Mon Mar 12 19:05:17 UTC 2012
I think it is sound to require all Themes to use their own public
namespace. Obviously, a Child Theme would by necessity use the Parent
Theme's namespace where appropriate. But in these cases, we're talking
about derivative - i.e. forked - Themes.
We currently require derivatives of Twenty Ten/Twenty Twelve to use their
own namespace for function names, hooks, etc. I see no reason to treat
Underscores derivatives any differently.
Anyone else have thoughts?
Chip
On Mon, Mar 12, 2012 at 1:54 PM, George Mamadashvili <
georgemamadashvili at gmail.com> wrote:
> Sorry, my bad.
>
> http://themes.trac.wordpress.org/ticket/6833
>
> Chip this theme has same issue as Toolbox 1.4 ( I asked about that early),
> not-prefixed actions and more other Automattic themes will have, cause
> they're based on _s theme. Pulled request on github to fix that, but theme
> wranglers have different opinion about that. Should I point that anyway?
> Here's GitHub issue URL -
> https://github.com/Automattic/_s/pull/6#issuecomment-4458047
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120312/78abc507/attachment.htm>
More information about the theme-reviewers
mailing list