[theme-reviewers] Something we need to check for 3.4 appearance -> background

[Otto]

On Mon, Jun 11, 2012 at 7:36 PM, Edward Caissie
<edward.caissie at gmail.com> wrote:
> Which leaves the dilemma, do I implement custom-backgrounds as you (@Otto)
> are recommending whereas I set the default I have chosen for the theme, and
> let the chips fall where they may ... or do I continue with not setting the
> defaults and leaving the background styles in the stylesheet where they have
> been from the theme's inception.

Neither. You shouldn't be setting default backgrounds for some special
case, you should be *using* the custom-background tool that the theme
is providing you to set the background for the website.

Why set the backgrounds in a child theme instead of just, you know,
setting the custom background to be the custom background you want it
to be?

Alternatively, if it is such a big problem for your clients to be able
to set custom backgrounds in the first place, then this code works
perfectly well:

add_action('after_setup_theme','child_setup',20);
function child_setup() {
   remove_theme_support('custom-background');
}

Bottom line is that if the theme supports custom backgrounds, and
you're not using the custom backgrounds properly, then you should
either use it properly or remove it. Leaving it there while setting
the background in an alternate manner is just asking for problems.

-Otto