[theme-reviewers] Something we need to check for 3.4 appearance -> background

[Chip Bennett]

I favor this approach. If an optional core feature is implemented, it is
REQUIRED to be implemented properly. As of WordPress 3.4, *proper*
implementation of the custom background feature includes not specifying a
body background via style.css.

Bear in mind: this is an API change, essentially. Sometimes things aren't
perfectly backward-compatible when an API changes. Some child Themes may
need some (probably minor) revisions in order to remain compatible.

Chip

On Mon, Jun 11, 2012 at 5:29 PM, Amy Hendrix <sabreuse at gmail.com> wrote:

> or "If the theme uses the core custom-background functionality, a
> background MUST NOT be specified in the stylesheet. This will ensure
> that end users can change or remove the background with the expected
> results."
>
> On Mon, Jun 11, 2012 at 6:21 PM, Otto <otto at ottodestruct.com> wrote:
> > On Mon, Jun 11, 2012 at 2:20 PM, Philip M. Hofer (Frumph)
> > <philip at frumph.net> wrote:
> >> While I see  what you're saying, and it's very valid.  It is not the
> >> behavior that would be the most beneficial to creators.
> >
> > Here's one possible example of a rule that will need to be REQUIRED as
> > of 3.4 because of this reversion:
> >
> > - If the theme uses the core custom-background functionality, and also
> > specifies a background-image for the site in the stylesheet, then the
> > background image MUST be on the body tag, and the
> > body.custom-background MUST have background-image: none as a rule in
> > the stylesheet as well. This is to ensure that the custom background
> > image functionality works properly when the user elects to not have a
> > background-image.
> >
> > You asked for it, you got it. Now make sure it gets done right.
> >
> > -Otto
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120611/a7a27a5c/attachment-0001.htm>