[theme-reviewers] Something we need to check for 3.4 appearance -> background

Philip M. Hofer (Frumph) philip at frumph.net
Mon Jun 11 22:43:21 UTC 2012


I like the wording, but what if the theme designer has a fallback of an 
image "by design" ?

If the end user of the theme wants to customize it further they have plenty 
of avenues they have been using for many years to remove a background image.



-----Original Message----- 
From: Amy Hendrix
Sent: Monday, June 11, 2012 3:29 PM
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Something we need to check for 3.4 
appearance -> background

or "If the theme uses the core custom-background functionality, a
background MUST NOT be specified in the stylesheet. This will ensure
that end users can change or remove the background with the expected
results."

On Mon, Jun 11, 2012 at 6:21 PM, Otto <otto at ottodestruct.com> wrote:
> On Mon, Jun 11, 2012 at 2:20 PM, Philip M. Hofer (Frumph)
> <philip at frumph.net> wrote:
>> While I see  what you're saying, and it's very valid.  It is not the
>> behavior that would be the most beneficial to creators.
>
> Here's one possible example of a rule that will need to be REQUIRED as
> of 3.4 because of this reversion:
>
> - If the theme uses the core custom-background functionality, and also
> specifies a background-image for the site in the stylesheet, then the
> background image MUST be on the body tag, and the
> body.custom-background MUST have background-image: none as a rule in
> the stylesheet as well. This is to ensure that the custom background
> image functionality works properly when the user elects to not have a
> background-image.
>
> You asked for it, you got it. Now make sure it gets done right.
>
> -Otto
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers 



More information about the theme-reviewers mailing list