[theme-reviewers] Something we need to check for 3.4 appearance -> background

Philip M. Hofer (Frumph) philip at frumph.net
Mon Jun 11 18:33:59 UTC 2012


Because of the coding of how appearance -> background works in 3.4 there is 
going to be a problem with 'parent' themes setting default images and colors 
to their theme. (probably just images from what I read)

The problem:

If a parent theme sets an image as a default in the $args,  it will forever 
then be required to use the appearance -> background

Why:

Order of execution, even if you remove the background image and color from 
the background -> appearance it still sets background-image: none;  even 
after cleared.

What this does?

This makes it so that any image set from the style.css either child theme or 
parent theme or even plugin will be ignored completely.

-------

What we need to look for.

If the theme in question ever wants to have child themes associated with it, 
then the main theme must *not* set defaults in the $args in 3.4

Since we want everyone to be child theme capable.   Then if any defaults are 
set in the parent theme they need to be removed or child themes simply will 
not work when setting a new image for that child theme.


---

This might change if the logic changes before release, but this is how it is 
right now.  according to:

http://core.trac.wordpress.org/ticket/20448






More information about the theme-reviewers mailing list