[theme-reviewers] (no subject)

[Chip Bennett]

I agree with Phil.

This statement is not in the Guidelines:

Site information is REQUIRED to be called using the correct template tag:
get_stylesheet_uri() rather than get_stylesheet_directory_uri() .
'/style.css'


What IS in the Guidelines is this:

Themes are *required* to use *_url() template tags, rather than bloginfo()
 equivalents.
AND
Themes are *required* to use
get_stylesheet_directory()<http://codex.wordpress.org/Function_Reference/get_stylesheet_directory>
rather
than STYLESHEETPATH to return the stylesheet path.


The important points:

   - Use get_stylesheet_directory() instead of the STYLESHEETPATH constant
   - Use get_stylesheet_directory*() instead of its get_bloginfo()
   equivalent
   - Use get_stylesheet_directory*() instead of get_template_directory*()
   when the included path is intended to be able to be overridden by a Child
   Theme


Chip

On Fri, Jun 8, 2012 at 8:44 AM, Philip M. Hofer (Frumph)
<philip at frumph.net>wrote:

>   Okay this is a little bit out of hand.
>
> ^ reference
>
> Site information is REQUIRED to be called using the correct template tag:
> get_stylesheet_uri() rather than get_stylesheet_directory_uri() .
> '/style.css'
>
>
> ^ Both are internal functions that do the EXACT same thing:
>
> Case:
>
> function get_stylesheet_uri() {
>     $stylesheet_dir_uri = get_stylesheet_directory_uri();
>     $stylesheet_uri = $stylesheet_dir_uri . '/style.css';
>     return apply_filters('stylesheet_uri', $stylesheet_uri,
> $stylesheet_dir_uri);
> }
>
> This is not a reason to invalidate a theme.  Neither is adding remaining
> parameters on a completely valid function call.
>
>
>
>  *From:* George Mamadashvili <georgemamadashvili at gmail.com>
> *Sent:* Friday, June 08, 2012 5:43 AM
> *To:* theme-reviewers at lists.wordpress.org
> *Subject:* Re: [theme-reviewers] (no subject)
>
> Use more simple solution -  wp_enqueue_style( 'krakatau-style',
> get_stylesheet_uri() );
>
> You need to use get_stylesheet_* functions when enqueueing style.css so
> child themes can easily override it.
>
> On Fri, Jun 8, 2012 at 2:39 PM, hal-android <hasilent00 at gmail.com> wrote:
>
>> Hi.
>> Can anyone help me here?
>> I'm really confused about this.
>> In the previous ticket :
>> http://themes.trac.wordpress.org/ticket/8039
>> wp_register_style('default', get_stylesheet_directory_uri() .
>> '/style.css', array(), '0.0.3');
>> wp_enqueue_style('default');
>>
>>
>> And on this ticket I replace
>> http://themes.trac.wordpress.org/ticket/8069#comment:3
>>
>> wp_enqueue_style('krakatau_style', get_template_directory_uri() .
>> '/style.css', array(), '0.0.5');
>>
>>
>> Please help me..what should i do?
>>
>> Many thank's
>> amdhas
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>
>
> ------------------------------
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120608/19d9a575/attachment.htm>