[theme-reviewers] [WordPress Themes] #7867: THEME: Simple Catch - 1.1

[Sakin Shrestha]

Hi Emil,

For the Admin Enqueue I had created simplecatch_admin_scripts() and
simplecatch_admin_styles() which is called only in admin section inside the
function simplecatch_options_menu()     // admin_print_scripts-(hookname)
and add_print_styles-(hookname)
    add_action( 'admin_print_scripts-' . $simplecatch_options,
'simplecatch_admin_scripts' );
    add_action( 'admin_print_styles-' . $simplecatch_options,
'simplecatch_admin_styles' );

    // admin_print_scripts-(hookname) and add_print_styles-(hookname)
    add_action( 'admin_print_scripts-' . $slider_options,
'simplecatch_admin_scripts' );
    add_action( 'admin_print_styles-' . $slider_options,
'simplecatch_admin_styles' );

I have pasted the code as below. Isn't this correct as this similar to what
you have mention to the comment. I think this should also work. If not then
can you tell me why not.

Regards,
Sakin

/**
 * Enqueue admin script
 *
 * @uses wp_enqueue_script
 * @Calling jquery, jquery-ui-tabs,jquery-cookie, jquery-ui-sortable,
jquery-ui-draggable
 */
function simplecatch_admin_scripts() {
    //jquery-cookie registered in functions.php
    wp_register_script( 'simplecatch_admin',
get_template_directory_uri().'/functions/panel/admin.js', array( 'jquery',
'jquery-ui-tabs', 'jquery-cookie', 'jquery-ui-sortable',
'jquery-ui-draggable' ), '1.0', false );
    wp_enqueue_script ( 'simplecatch_admin' );
    //registering add_image_script.js and enqueue
    wp_register_script( 'simplecatch_upload',
get_template_directory_uri().'/functions/panel/add_image_scripts.js',
array( 'jquery','media-upload','thickbox' ) );
    wp_enqueue_script( 'simplecatch_upload' );
}


/**
 * Enqueue admin stylesheet
 *
 * @uses wp_enqueue_style
 */
function simplecatch_admin_styles() {
    wp_enqueue_style(
'simplecatch_admin',get_template_directory_uri().'/functions/panel/admin.css',
array(), '1.0', 'screen' );
    //Enqueue thickbox.css
    wp_enqueue_style( 'thickbox' );
}


/*
 * Create a function for Theme Options Page
 *
 * @uses add_menu_page
 * @add action admin_menu
 */
add_action( 'admin_menu', 'simplecatch_options_menu' );
function simplecatch_options_menu() {

    $simplecatch_options = add_theme_page(
        sprintf( esc_html__( '%s Theme Options', 'simplecatch' ),
get_bloginfo( 'name') ), // Name of page
        __( 'Theme Options', 'simplecatch' ),        // Label in menu
        'edit_theme_options',                         // Capability required
        'simplecatch_options',                             // Menu slug,
used to uniquely identify the page
        'simplecatch_options_page'
    );                        // Function that renders the options page

    $slider_options = add_theme_page(
        sprintf( esc_html__( '%s Slider', 'simplecatch' ), get_bloginfo(
'name') ), // Name of page
        __( 'Featured Slider', 'simplecatch' ),        // Label in menu
        'edit_theme_options',                         // Capability required
        'simplecatch_options_slider',                             // Menu
slug, used to uniquely identify the page
        'simplecatch_options_slider_page'    // Function that renders the
options page
    );

    // admin_print_scripts-(hookname) and add_print_styles-(hookname)
    add_action( 'admin_print_scripts-' . $simplecatch_options,
'simplecatch_admin_scripts' );
    add_action( 'admin_print_styles-' . $simplecatch_options,
'simplecatch_admin_styles' );

    // admin_print_scripts-(hookname) and add_print_styles-(hookname)
    add_action( 'admin_print_scripts-' . $slider_options,
'simplecatch_admin_scripts' );
    add_action( 'admin_print_styles-' . $slider_options,
'simplecatch_admin_styles' );
}
add_action( 'admin_menu', 'simplecatch_options_menu' );
On Sun, Jun 3, 2012 at 3:10 PM, Emil Uzelac <emil at themeid.com> wrote:

> Hi,
>
> 2nd opinion will come from other admins or reviewers :)
>
> Emil
>
>  On Sun, Jun 3, 2012 at 4:24 AM, Sakin Shrestha <info at catchinternet.com>wrote:
>
>>  Hi Emil,
>>
>> Sorry this is not my question. My question if that why my theme is being
>> issue for IE specific style and scripts. Where I can see your WordPress
>> default theme Twenty Eleven theme is using it. This is not fair. If my
>> theme is check against this script then twenty eleven theme should also be
>> checked. This should be equal to everyone.
>>
>> Another is about the *License: (2nd opinion needed). *I asked you help
>> in this as I am new to theme development in WordPress repo. So, if you help
>> me with this that What should I add it additional for this css
>> http://978.gs
>>
>> Regards,
>> Sakin
>>
>> On Sun, Jun 3, 2012 at 2:56 PM, WordPress Themes <
>> theme-reviewers at lists.wordpress.org> wrote:
>>
>>> #7867: THEME: Simple Catch - 1.1
>>> -------------------------------+-----------------------
>>> Reporter:  catchthemes         |       Owner:  figerty
>>>    Type:  theme               |      Status:  reopened
>>> Priority:  major               |  Resolution:
>>> Keywords:  theme-simple-catch  |
>>> -------------------------------+-----------------------
>>>
>>> Comment (by emiluzelac):
>>>
>>>  For styles you can use [http://modernizr.com/ Modernizr]. It's easy and
>>>  very effective too and go after specific IE browsers. Since we don't
>>> have
>>>  any good if IE alternatives you can disregard that. I do know that
>>> default
>>>  Theme is using it and perhaps that also is not the best solution either.
>>>
>>> --
>>> Ticket URL: <http://themes.trac.wordpress.org/ticket/7867#comment:5>
>>> WordPress Themes <http://themes.trac.wordpress.org/>
>>> WordPress.org Theme Directory Reviews
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120603/071f88ac/attachment-0001.htm>