[theme-reviewers] Is this now a requirement for submitted themes?

[Edward Caissie]

The "best practice" use of modifying the `wp_title` output via a filter
call is required, but mostly as a "best practice" and to insure it "plays
nice" with plugins, specifically the SEO varieties.
IF the theme has already been approved, then obviously any new updates
should include the more correct best practice method; if this is the only
"fix" being added in the submission, I would also imagine it would be a
very quick diff review and resolved as approved ... personally, I would
simply write the modification and submit it now.


Cais.


On Tue, Jul 3, 2012 at 7:27 AM, Shinra Web Holdings <
shinrawebholdings at gmail.com> wrote:

> Yes, it's required now. Plugin authors were getting mad that they couldn't
> fully change the title (since bloginfo('name') was typically hardcoded in,
> so now it is required to use the wp_title filter. I put a function on the
> codex page that you can pretty much take verbatim.
>
>
> On Tue, Jul 3, 2012 at 4:38 AM, Konstantin Obenland <
> konstantin at obenland.it> wrote:
>
>> I don't know how others see it, but I would't consider it urgent enough
>> for immediate action. Just have it fixed the next time you get around to
>> submitting an update. :)
>>
>> Konstantin
>>
>> On 03.07.2012, at 11:29, esmi at quirm dot net wrote:
>>
>> > on 03/07/2012 08:00 Konstantin Obenland said the following:
>> >> Your Theme was first approved almost two years ago and a lot has
>> >> changed since then. If you want to stay on top of all changes, you
>> >> might want to check out the Theme Review Codex page regularly and/or
>> >> weigh in on the discussions we have on make.wordpress.org/themes for
>> >> new and changing requirements.
>> >
>> > I do try to do both but somehow this slipped past me. :-) Are you ok
>> for the theme to be released on the Repo "as is"? Or would you prefer me to
>> re-submit an amended version?  I have 3 other themes I'm updating and I
>> don't want to give you guys even more work if it can be avoided.
>> >
>> > Mel
>> > --
>> > http://quirm.net
>> > http://blackwidows.co.uk
>> >
>> >
>> > _______________________________________________
>> > theme-reviewers mailing list
>> > theme-reviewers at lists.wordpress.org
>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120703/cd84e1d1/attachment.htm>