The "best practice" use of modifying the `wp_title` output via a filter call is required, but mostly as a "best practice" and to insure it "plays nice" with plugins, specifically the SEO varieties.<br>
IF the theme has already been approved, then obviously any new updates should include the more correct best practice method; if this is the only "fix" being added in the submission, I would also imagine it would be a very quick diff review and resolved as approved ... personally, I would simply write the modification and submit it now.<br>
<br><br clear="all">Cais.<br>
<br><br><div class="gmail_quote">On Tue, Jul 3, 2012 at 7:27 AM, Shinra Web Holdings <span dir="ltr"><<a href="mailto:shinrawebholdings@gmail.com" target="_blank">shinrawebholdings@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yes, it's required now. Plugin authors were getting mad that they couldn't fully change the title (since bloginfo('name') was typically hardcoded in, so now it is required to use the wp_title filter. I put a function on the codex page that you can pretty much take verbatim.<div class="HOEnZb">
<div class="h5"><br>
<br><div class="gmail_quote">On Tue, Jul 3, 2012 at 4:38 AM, Konstantin Obenland <span dir="ltr"><<a href="mailto:konstantin@obenland.it" target="_blank">konstantin@obenland.it</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't know how others see it, but I would't consider it urgent enough for immediate action. Just have it fixed the next time you get around to submitting an update. :)<br>
<span><font color="#888888"><br>
Konstantin<br>
</font></span><div><div><br>
On 03.07.2012, at 11:29, esmi at quirm dot net wrote:<br>
<br>
> on 03/07/2012 08:00 Konstantin Obenland said the following:<br>
>> Your Theme was first approved almost two years ago and a lot has<br>
>> changed since then. If you want to stay on top of all changes, you<br>
>> might want to check out the Theme Review Codex page regularly and/or<br>
>> weigh in on the discussions we have on <a href="http://make.wordpress.org/themes" target="_blank">make.wordpress.org/themes</a> for<br>
>> new and changing requirements.<br>
><br>
> I do try to do both but somehow this slipped past me. :-) Are you ok for the theme to be released on the Repo "as is"? Or would you prefer me to re-submit an amended version? I have 3 other themes I'm updating and I don't want to give you guys even more work if it can be avoided.<br>
><br>
> Mel<br>
> --<br>
> <a href="http://quirm.net" target="_blank">http://quirm.net</a><br>
> <a href="http://blackwidows.co.uk" target="_blank">http://blackwidows.co.uk</a><br>
><br>
><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>