[theme-reviewers] unable to upload please advice

Thu Aug 23 12:16:53 UTC 2012

But the issue is that the Guidelines allow for certain backward
compatibility, but apparently the uploader is preventing upload. Whether
the RegEx can/needs to be changed, or just the criticality level needs to
be lowered so that upload doesn't fail, the end result is a "false
positive" that is preventing upload.

Chip

On Thu, Aug 23, 2012 at 7:13 AM, Simon Prosser <pross at pross.org.uk> wrote:

> There is no way on earth a regex can check to see if the function is
> inside an IF/ELSE.
> So it either looks for it or not.
>
> My view would be do a if < 3.4 show warning message for user to
> upgrade or fail gracefully.
>
> On 23 August 2012 12:37, Chip Bennett <chip at chipbennett.net> wrote:
> > I would love to get to the point where the official repository formally
> does
> > not support backward compatibility. But it's simply not realistic at this
> > point. Almost 40% of WordPress installs still use a version older than
> 3.3,
> > and almost 30% are older than 3.2:
> > http://wordpress.org/about/stats/
> >
> > That's the real reason that the guidelines are written the way they are,
> > recommending no backward compatibility beyond one major version, and
> > requiring no backward compatibility beyond two major versions.
> >
> > It's a cart-and-horse scenario, and as much as I would like it to be, I'm
> > not sure that the Theme repository is quite yet in position to be the
> horse.
> >
> > Chip
> >
> >
> > On Thu, Aug 23, 2012 at 6:14 AM, Philip M. Hofer (Frumph)
> > <philip at frumph.net> wrote:
> >>
> >> I consider not making things backwards compatible since we want people
> to
> >> upgrade their WordPress to stay current with the latest bug
> fixes/exploit
> >> fixes as well.
> >>
> >> From: Petar Genev
> >> Sent: Thursday, August 23, 2012 4:04 AM
> >> To: theme-reviewers at lists.wordpress.org
> >> Subject: Re: [theme-reviewers] unable to upload please advice
> >>
> >> Ok so let me know what to do and I will do it. I would prefer keeping in
> >> mind the old wp versions but if you say you want only the last one this
> is
> >> what I will do.
> >>
> >> Thanks :-)
> >>
> >> Petar
> >>
> >> On Thu, Aug 23, 2012 at 11:49 AM, Bryan Hadaway <bhadaway at gmail.com>
> >> wrote:
> >>>
> >>> I remember now reading about it, here it is:
> >>>
> >>> http://codex.wordpress.org/Theme_Review#Code_Quality
> >>>
> >>> So it's sort of a yes and no situation.
> >>>
> >>>
> >>>
> >>> Bryan Phillip Hadaway
> >>>
> >>>
> >>> Web & Graphic Designer
> >>> calmestghost.com
> >>> bhadaway at gmail.com
> >>>
> >>>
> >>> Socialize: Facebook | Twitter | LinkedIn | Google+
> >>>
> >>>
> >>>
> >>>
> >>> On Thu, Aug 23, 2012 at 1:14 AM, Emil Uzelac <emil at themeid.com> wrote:
> >>>>
> >>>> Many Themes, including Twenty Eleven use backward compatibility, this
> >>>> isn't anything out of the ordinary :) Not sure what the codes are and
> this
> >>>> is also something Otto would need to see as well.
> >>>>
> >>>> It's entirely up to you, to wait awhile or re-submit without them.
> >>>>
> >>>> Emil
> >>>>
> >>>> On Thu, Aug 23, 2012 at 3:02 AM, Petar Genev <petar.genev at gmail.com>
> >>>> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> Yes. If possible I'd like to support the 3.3. and 3.4 versions as
> well.
> >>>>> If not I will move to the new functions and support the latest
> version of WP
> >>>>> only.
> >>>>>
> >>>>> Let me know how to proceed.
> >>>>>
> >>>>> Thanks! :-)
> >>>>>
> >>>>> Peter
> >>>>>
> >>>>>
> >>>>> On Thu, Aug 23, 2012 at 10:57 AM, Emil Uzelac <emil at themeid.com>
> wrote:
> >>>>>>
> >>>>>> Hi Petar,
> >>>>>>
> >>>>>> So this is for backward compatibility only, I would leave this for
> >>>>>> Otto (when time permits).
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Emil
> >>>>>>
> >>>>>> On Wed, Aug 22, 2012 at 11:26 PM, Petar Genev <
> petar.genev at gmail.com>
> >>>>>> wrote:
> >>>>>>>
> >>>>>>> Hi there,
> >>>>>>>
> >>>>>>> I am trying to upload a theme via
> >>>>>>> http://wordpress.org/extend/themes/upload/
> >>>>>>> I get the following two errors:
> >>>>>>>
> >>>>>>> REQUIRED: add_contextual_help found in the file theme-options.php.
> >>>>>>> Deprecated since version 3.3. Use
> get_current_screen()->add_help_tab()
> >>>>>>> instead.
> >>>>>>> RECOMMENDED: get_current_theme found in the file theme-options.php.
> >>>>>>> Deprecated since version 3.4. Use wp_get_theme() instead.
> >>>>>>>
> >>>>>>> I do not consider those two as errors because in the code I make an
> >>>>>>> IF statement that checks if the new function exists and if it does
> not it
> >>>>>>> would call the old one. This is how I make sure I use the new
> function if
> >>>>>>> the wordpress installation is new version and use the old function
> on old wp
> >>>>>>> installations.
> >>>>>>> I can easily use only the new functions but then my theme will not
> >>>>>>> work fine on old versions of WP which I'd like my theme to
> support. By old
> >>>>>>> versions I mean 3.3 and 3.4.
> >>>>>>>
> >>>>>>> For example:
> >>>>>>> <?php $theme_name = function_exists( 'wp_get_theme' ) ?
> >>>>>>> wp_get_theme() : get_current_theme(); ?>
> >>>>>>>
> >>>>>>> I think the theme checker finds the old function as a text in the
> >>>>>>> codes and rises the errors without following the logic in the IF
> statements.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Please tell me what can I do so I can upload my theme?
> >>>>>>>
> >>>>>>> Petar
> >>>>>>>
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> theme-reviewers mailing list
> >>>>>>> theme-reviewers at lists.wordpress.org
> >>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> theme-reviewers mailing list
> >>>>>> theme-reviewers at lists.wordpress.org
> >>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >>>>>>
> >>>>>
> >>>>>
> >>>>> _______________________________________________
> >>>>> theme-reviewers mailing list
> >>>>> theme-reviewers at lists.wordpress.org
> >>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >>>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> theme-reviewers mailing list
> >>>> theme-reviewers at lists.wordpress.org
> >>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >>>>
> >>>
> >>>
> >>> _______________________________________________
> >>> theme-reviewers mailing list
> >>> theme-reviewers at lists.wordpress.org
> >>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >>>
> >>
> >> ________________________________
> >> _______________________________________________
> >> theme-reviewers mailing list
> >> theme-reviewers at lists.wordpress.org
> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >>
> >>
> >> _______________________________________________
> >> theme-reviewers mailing list
> >> theme-reviewers at lists.wordpress.org
> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >>
> >
> >
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
>
>
>
> --
> My Blog: http://pross.org.uk/
> Plugins : http://pross.org.uk/plugins/
> Themes: http://wordpress.org/extend/themes/profile/pross
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120823/c56db2a9/attachment-0001.htm>