[theme-reviewers] unable to upload please advice

[Otto]

On Thu, Aug 23, 2012 at 7:16 AM, Chip Bennett <chip at chipbennett.net> wrote:
> But the issue is that the Guidelines allow for certain backward
> compatibility, but apparently the uploader is preventing upload. Whether the
> RegEx can/needs to be changed, or just the criticality level needs to be
> lowered so that upload doesn't fail, the end result is a "false positive"
> that is preventing upload.

The uploader (theme check) is correct. Look at the error:

REQUIRED: add_contextual_help found in the file theme-options.php.
Deprecated since version 3.3. Use get_current_screen()->add_help_tab()
instead.

add_contextual_help was deprecated in 3.3. The guidelines state (or
once stated) that backward compatibility would only be supported for
two major versions. Well, that's two major versions, 3.3 and 3.4.
add_contextual_help is a 3.2 thing, and therefore outside the
guidelines.

So, no error here. If you want to change theme check to make that
recommended, then you need to adjust the guidelines.