But the issue is that the Guidelines allow for certain backward compatibility, but apparently the uploader is preventing upload. Whether the RegEx can/needs to be changed, or just the criticality level needs to be lowered so that upload doesn't fail, the end result is a "false positive" that is preventing upload.<div>
<br></div><div>Chip<br><br><div class="gmail_quote">On Thu, Aug 23, 2012 at 7:13 AM, Simon Prosser <span dir="ltr"><<a href="mailto:pross@pross.org.uk" target="_blank">pross@pross.org.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
There is no way on earth a regex can check to see if the function is<br>
inside an IF/ELSE.<br>
So it either looks for it or not.<br>
<br>
My view would be do a if < 3.4 show warning message for user to<br>
upgrade or fail gracefully.<br>
<div class="HOEnZb"><div class="h5"><br>
On 23 August 2012 12:37, Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>> wrote:<br>
> I would love to get to the point where the official repository formally does<br>
> not support backward compatibility. But it's simply not realistic at this<br>
> point. Almost 40% of WordPress installs still use a version older than 3.3,<br>
> and almost 30% are older than 3.2:<br>
> <a href="http://wordpress.org/about/stats/" target="_blank">http://wordpress.org/about/stats/</a><br>
><br>
> That's the real reason that the guidelines are written the way they are,<br>
> recommending no backward compatibility beyond one major version, and<br>
> requiring no backward compatibility beyond two major versions.<br>
><br>
> It's a cart-and-horse scenario, and as much as I would like it to be, I'm<br>
> not sure that the Theme repository is quite yet in position to be the horse.<br>
><br>
> Chip<br>
><br>
><br>
> On Thu, Aug 23, 2012 at 6:14 AM, Philip M. Hofer (Frumph)<br>
> <<a href="mailto:philip@frumph.net">philip@frumph.net</a>> wrote:<br>
>><br>
>> I consider not making things backwards compatible since we want people to<br>
>> upgrade their WordPress to stay current with the latest bug fixes/exploit<br>
>> fixes as well.<br>
>><br>
>> From: Petar Genev<br>
>> Sent: Thursday, August 23, 2012 4:04 AM<br>
>> To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> Subject: Re: [theme-reviewers] unable to upload please advice<br>
>><br>
>> Ok so let me know what to do and I will do it. I would prefer keeping in<br>
>> mind the old wp versions but if you say you want only the last one this is<br>
>> what I will do.<br>
>><br>
>> Thanks :-)<br>
>><br>
>> Petar<br>
>><br>
>> On Thu, Aug 23, 2012 at 11:49 AM, Bryan Hadaway <<a href="mailto:bhadaway@gmail.com">bhadaway@gmail.com</a>><br>
>> wrote:<br>
>>><br>
>>> I remember now reading about it, here it is:<br>
>>><br>
>>> <a href="http://codex.wordpress.org/Theme_Review#Code_Quality" target="_blank">http://codex.wordpress.org/Theme_Review#Code_Quality</a><br>
>>><br>
>>> So it's sort of a yes and no situation.<br>
>>><br>
>>><br>
>>><br>
>>> Bryan Phillip Hadaway<br>
>>><br>
>>><br>
>>> Web & Graphic Designer<br>
>>> <a href="http://calmestghost.com" target="_blank">calmestghost.com</a><br>
>>> <a href="mailto:bhadaway@gmail.com">bhadaway@gmail.com</a><br>
>>><br>
>>><br>
>>> Socialize: Facebook | Twitter | LinkedIn | Google+<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> On Thu, Aug 23, 2012 at 1:14 AM, Emil Uzelac <<a href="mailto:emil@themeid.com">emil@themeid.com</a>> wrote:<br>
>>>><br>
>>>> Many Themes, including Twenty Eleven use backward compatibility, this<br>
>>>> isn't anything out of the ordinary :) Not sure what the codes are and this<br>
>>>> is also something Otto would need to see as well.<br>
>>>><br>
>>>> It's entirely up to you, to wait awhile or re-submit without them.<br>
>>>><br>
>>>> Emil<br>
>>>><br>
>>>> On Thu, Aug 23, 2012 at 3:02 AM, Petar Genev <<a href="mailto:petar.genev@gmail.com">petar.genev@gmail.com</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> Hi,<br>
>>>>><br>
>>>>> Yes. If possible I'd like to support the 3.3. and 3.4 versions as well.<br>
>>>>> If not I will move to the new functions and support the latest version of WP<br>
>>>>> only.<br>
>>>>><br>
>>>>> Let me know how to proceed.<br>
>>>>><br>
>>>>> Thanks! :-)<br>
>>>>><br>
>>>>> Peter<br>
>>>>><br>
>>>>><br>
>>>>> On Thu, Aug 23, 2012 at 10:57 AM, Emil Uzelac <<a href="mailto:emil@themeid.com">emil@themeid.com</a>> wrote:<br>
>>>>>><br>
>>>>>> Hi Petar,<br>
>>>>>><br>
>>>>>> So this is for backward compatibility only, I would leave this for<br>
>>>>>> Otto (when time permits).<br>
>>>>>><br>
>>>>>> Thanks,<br>
>>>>>> Emil<br>
>>>>>><br>
>>>>>> On Wed, Aug 22, 2012 at 11:26 PM, Petar Genev <<a href="mailto:petar.genev@gmail.com">petar.genev@gmail.com</a>><br>
>>>>>> wrote:<br>
>>>>>>><br>
>>>>>>> Hi there,<br>
>>>>>>><br>
>>>>>>> I am trying to upload a theme via<br>
>>>>>>> <a href="http://wordpress.org/extend/themes/upload/" target="_blank">http://wordpress.org/extend/themes/upload/</a><br>
>>>>>>> I get the following two errors:<br>
>>>>>>><br>
>>>>>>> REQUIRED: add_contextual_help found in the file theme-options.php.<br>
>>>>>>> Deprecated since version 3.3. Use get_current_screen()->add_help_tab()<br>
>>>>>>> instead.<br>
>>>>>>> RECOMMENDED: get_current_theme found in the file theme-options.php.<br>
>>>>>>> Deprecated since version 3.4. Use wp_get_theme() instead.<br>
>>>>>>><br>
>>>>>>> I do not consider those two as errors because in the code I make an<br>
>>>>>>> IF statement that checks if the new function exists and if it does not it<br>
>>>>>>> would call the old one. This is how I make sure I use the new function if<br>
>>>>>>> the wordpress installation is new version and use the old function on old wp<br>
>>>>>>> installations.<br>
>>>>>>> I can easily use only the new functions but then my theme will not<br>
>>>>>>> work fine on old versions of WP which I'd like my theme to support. By old<br>
>>>>>>> versions I mean 3.3 and 3.4.<br>
>>>>>>><br>
>>>>>>> For example:<br>
>>>>>>> <?php $theme_name = function_exists( 'wp_get_theme' ) ?<br>
>>>>>>> wp_get_theme() : get_current_theme(); ?><br>
>>>>>>><br>
>>>>>>> I think the theme checker finds the old function as a text in the<br>
>>>>>>> codes and rises the errors without following the logic in the IF statements.<br>
>>>>>>><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> Please tell me what can I do so I can upload my theme?<br>
>>>>>>><br>
>>>>>>> Petar<br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> _______________________________________________<br>
>>>>>>> theme-reviewers mailing list<br>
>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>>><br>
>>>>>><br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> theme-reviewers mailing list<br>
>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>><br>
>>>>><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> theme-reviewers mailing list<br>
>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>
>>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>
>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>
>><br>
>> ________________________________<br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
My Blog: <a href="http://pross.org.uk/" target="_blank">http://pross.org.uk/</a><br>
Plugins : <a href="http://pross.org.uk/plugins/" target="_blank">http://pross.org.uk/plugins/</a><br>
Themes: <a href="http://wordpress.org/extend/themes/profile/pross" target="_blank">http://wordpress.org/extend/themes/profile/pross</a><br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div>