[theme-reviewers] how to handle 3.3 deprecated notice?

[Chip Bennett]

That's more like what I'm trying to get at: if these are things that we
*should* have been enforcing, but weren't doing so completely/correctly,
then I'm fine with beginning to enforce them as we see them via
_doing_it_wrong.

But, I'm trying to balance that with ensuring that we don't change
Guidelines/standards mid-stream, because we do our best to ensure that we
only make major changes to the Guidelines/enforcement according to a
pre-determined schedule (currently: one month after release of major
WordPress versions). So, that's why I was asking for clarification.

I second, and reiterate, your admonition that *Theme developers should now
be testing/developing against WordPress 3.3 pre-release versions (currently
at beta2), and Theme Reviewers should likewise be testing against 3.3
pre-release.*

So, as far as I'm concerned: enforcement of 3.3 pre-release _doing_it_wrong
notices is informal/unofficial, but I would support any reviewer who lists
such notices as REQUIRED.

Chip

On Mon, Oct 24, 2011 at 8:06 PM, Dion Hulse (dd32) <wordpress at dd32.id.au>wrote:

> It **may** have worked in WordPress 3.2 depending on varying
> circumstances, but definitely should have never been done that way in the
> first place.* It may work, or most likely won't work, as expected in 3.3.
> *
>
> Regardless of theme reviewers guidelines,* Theme authors: Please do test
> with WordPress 3.3beta's*, and please do take notice of the warnings
> generated.
>
> Doing it wrong notices, are just that, You're doing something wrong, both
> in 3.3 and earlier, it may work, or it may not work, but you're gambling on
> your theme working in future releases.
>
> If it's a deprecated notice (which this isn't) and the replacement function
> doesn't exist in 3.2, and you're planning on releasing immediately, then by
> all means, use the 3.2 compatible function. If it's likely to be released
> after 3.3, you're doing yourself a disservice by supporting 3.2 in most
> cases.. With all the hard work you put into a theme, having to support older
> versions of WordPress is a service few should need to consider.
>
> In this case, the theme could pass through the Theme review guidelines by
> the sounds of it, but just because it can pass, it doesn't mean you can't do
> better.
>
> On 25 October 2011 02:42, Chip Bennett <chip at chipbennett.net> wrote:
>
>> But did it *not work* in WordPress 3.2, or did it *always* not work, and
>> is only now being *reported as such* in WordPress 3.3?
>>
>> If the issue is improper hooking of enqueue calls, then absolutely; I
>> agree: require the enqueue call to be hooked properly, since that's already
>> being enforced.
>>
>> Chip
>>
>>
>> On Mon, Oct 24, 2011 at 10:35 AM, Otto <otto at ottodestruct.com> wrote:
>>
>>> Triggering of the _doing_it_wrong isn't exactly a "deprecation". If
>>> that's triggered, then the plugin/theme/whatever is triggering it is,
>>> basically, broken.
>>>
>>> In this particular case, if you try to enqueue a script too early,
>>> before the $wp_scripts has initialized, then the script won't be able
>>> to enqueue properly.
>>>
>>> So it's not a matter of guidelines, as such. The code is broken. It
>>> don't work. So, it should be fixed.
>>>
>>> -Otto
>>>
>>>
>>>
>>> On Mon, Oct 24, 2011 at 10:29 AM, Chip Bennett <chip at chipbennett.net>
>>> wrote:
>>> > As a courtesy, note the deprecated function call as RECOMMENDED in the
>>> > review.
>>> > Enforcement of WordPress 3.3 function deprecation will be implemented
>>> > approximately one month following final release of WordPress 3.3, at
>>> which
>>> > time we will finalize/go live with the WordPress 3.3 Guidelines
>>> revisions.
>>> > Chip
>>> >
>>> > On Mon, Oct 24, 2011 at 10:22 AM, Otto <otto at ottodestruct.com> wrote:
>>> >>
>>> >> Please don't reply to digest emails.
>>> >>
>>> >> And no, I wouldn't ignore such things. 3.3 is in beta 2 and well on
>>> >> track for release very soon. It would be a good idea to future proof
>>> >> things.
>>> >>
>>> >> That message, BTW, comes to you courtesy of the "_doing_it_wrong"
>>> >> function in WordPress. If you trigger it, then you're doing something
>>> >> wrong.
>>> >>
>>> >> -Otto
>>> >>
>>> >>
>>> >>
>>> >> On Mon, Oct 24, 2011 at 10:13 AM, Paul de Wouters
>>> >> <pauldewouters at zoho.com> wrote:
>>> >> > Hi
>>> >> > Should I ignore deprecated notices relative to version 3.3?
>>> >> >
>>> >> > Scripts and styles should not be registered or enqueued until
>>> >> > thewp_enqueue_scripts, admin_enqueue_scripts, or init hooks. Please
>>> >> > seeDebugging in WordPress for more information.
>>> >> > This message was added in version 3.3.
>>> >> > Should testing be done using the current stable version?
>>> >> > thanks
>>> >> _______________________________________________
>>> >> theme-reviewers mailing list
>>> >> theme-reviewers at lists.wordpress.org
>>> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >
>>> >
>>> > _______________________________________________
>>> > theme-reviewers mailing list
>>> > theme-reviewers at lists.wordpress.org
>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >
>>> >
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20111024/cf21f2cc/attachment-0001.htm>