That's more like what I'm trying to get at: if these are things that we *should* have been enforcing, but weren't doing so completely/correctly, then I'm fine with beginning to enforce them as we see them via _doing_it_wrong.<div>
<br></div><div>But, I'm trying to balance that with ensuring that we don't change Guidelines/standards mid-stream, because we do our best to ensure that we only make major changes to the Guidelines/enforcement according to a pre-determined schedule (currently: one month after release of major WordPress versions). So, that's why I was asking for clarification.</div>
<div><br></div><div>I second, and reiterate, your admonition that <b>Theme developers should now be testing/developing against WordPress 3.3 pre-release versions (currently at beta2), and Theme Reviewers should likewise be testing against 3.3 pre-release.</b> </div>
<div><br></div><div>So, as far as I'm concerned: enforcement of 3.3 pre-release _doing_it_wrong notices is informal/unofficial, but I would support any reviewer who lists such notices as REQUIRED.</div><div><br></div>
<div>Chip<br><br><div class="gmail_quote">On Mon, Oct 24, 2011 at 8:06 PM, Dion Hulse (dd32) <span dir="ltr"><<a href="mailto:wordpress@dd32.id.au">wordpress@dd32.id.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>It <strong>*may*</strong> have worked in WordPress 3.2 depending on varying circumstances, but definitely should have never been done that way in the first place.<strong> It may work, or most likely won't work, as expected in 3.3. </strong><br>
</div><div><br></div><div>Regardless of theme reviewers guidelines,<strong> Theme authors: Please do test with WordPress 3.3beta's</strong>, and please do take notice of the warnings generated.</div><div><br></div><div>
Doing it wrong notices, are just that, You're doing something wrong, both in 3.3 and earlier, it may work, or it may not work, but you're gambling on your theme working in future releases.</div><div><br></div><div>
If it's a deprecated notice (which this isn't) and the replacement function doesn't exist in 3.2, and you're planning on releasing immediately, then by all means, use the 3.2 compatible function. If it's likely to be released after 3.3, you're doing yourself a disservice by supporting 3.2 in most cases.. With all the hard work you put into a theme, having to support older versions of WordPress is a service few should need to consider.</div>
<div><br></div><div>In this case, the theme could pass through the Theme review guidelines by the sounds of it, but just because it can pass, it doesn't mean you can't do better.</div><div><div></div><div class="h5">
<div><br></div><div class="gmail_quote">
On 25 October 2011 02:42, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
But did it *not work* in WordPress 3.2, or did it *always* not work, and is only now being *reported as such* in WordPress 3.3?<div><br></div><div>If the issue is improper hooking of enqueue calls, then absolutely; I agree: require the enqueue call to be hooked properly, since that's already being enforced.</div>
<div><br></div><div><font color="#888888">Chip</font><div><div><br><br><div class="gmail_quote">On Mon, Oct 24, 2011 at 10:35 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Triggering of the _doing_it_wrong isn't exactly a "deprecation". If<br>
that's triggered, then the plugin/theme/whatever is triggering it is,<br>
basically, broken.<br>
<br>
In this particular case, if you try to enqueue a script too early,<br>
before the $wp_scripts has initialized, then the script won't be able<br>
to enqueue properly.<br>
<br>
So it's not a matter of guidelines, as such. The code is broken. It<br>
don't work. So, it should be fixed.<br>
<font color="#888888"><br>
-Otto<br>
</font><div><div><br>
<br>
<br>
On Mon, Oct 24, 2011 at 10:29 AM, Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>> wrote:<br>
> As a courtesy, note the deprecated function call as RECOMMENDED in the<br>
> review.<br>
> Enforcement of WordPress 3.3 function deprecation will be implemented<br>
> approximately one month following final release of WordPress 3.3, at which<br>
> time we will finalize/go live with the WordPress 3.3 Guidelines revisions.<br>
> Chip<br>
><br>
> On Mon, Oct 24, 2011 at 10:22 AM, Otto <<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>> wrote:<br>
>><br>
>> Please don't reply to digest emails.<br>
>><br>
>> And no, I wouldn't ignore such things. 3.3 is in beta 2 and well on<br>
>> track for release very soon. It would be a good idea to future proof<br>
>> things.<br>
>><br>
>> That message, BTW, comes to you courtesy of the "_doing_it_wrong"<br>
>> function in WordPress. If you trigger it, then you're doing something<br>
>> wrong.<br>
>><br>
>> -Otto<br>
>><br>
>><br>
>><br>
>> On Mon, Oct 24, 2011 at 10:13 AM, Paul de Wouters<br>
>> <<a href="mailto:pauldewouters@zoho.com" target="_blank">pauldewouters@zoho.com</a>> wrote:<br>
>> > Hi<br>
>> > Should I ignore deprecated notices relative to version 3.3?<br>
>> ><br>
>> > Scripts and styles should not be registered or enqueued until<br>
>> > thewp_enqueue_scripts, admin_enqueue_scripts, or init hooks. Please<br>
>> > seeDebugging in WordPress for more information.<br>
>> > This message was added in version 3.3.<br>
>> > Should testing be done using the current stable version?<br>
>> > thanks<br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
><br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>