[theme-reviewers] Comments are closed on pages

[Justin Tadlock]

The reason my themes have a message is because I opened a discussion on 
my forums and had real theme users make the decision.  I have a lot of 
opinionated users too. :)  I wouldn't consider that rare or a special 
use case.  This was about a three-month discussion.

Also, there are several scenarios for this type of thing:

* No comments, comments closed, pings closed.
* No comments, comments closed, pings open.
* No comments, comments open, pings closed.
* Has comments, comments closed, pings closed.
* Has comments, comments closed, pings open.
* Has comments, comments open, pings closed.

I have these for posts and pages in my personal test data.  I don't 
think we have all of them in the theme unit test data.

Having a catchall requirement (based on our opinions) doesn't really cut 
it.  A theme developer has a lot of options just based on that list of 
how to handle comments.  Many people are going to look at it a different 
way and have their own opinion about the best method of handling comments.

There are some things I believe we should just leave up to the theme 
developer (this being one of those things).  Granted, 90% of the themes 
that come rolling through don't seem to have a lot of thought put behind 
them.

On 3/1/2011 7:56 PM, Edward Caissie wrote:
> The no "comments are closed" message is a legacy item that may need to 
> be reviewed. Although I agree with its current implementation 
> regarding pages I would be open to a compelling argument to allow for 
> special use cases; but, again, the Theme repository is not a 
> destination for rare use-case themes but one for themes that are 
> designed to meet a great many users needs and wants and essentially a 
> more or less generic use-case fashion.
>
>
> Cais.
>
> On Wed, Mar 2, 2011 at 7:02 PM, Justin Tadlock 
> <justin at justintadlock.com <mailto:justin at justintadlock.com>> wrote:
>
>     Actually, I would argue that this message should be displayed if
>     pings are open:
>
>     "Comments are closed but trackbacks and pingbacks are open."
>
>     I would never say a theme couldn't have that.  Even my themes show
>     a message similar to that.  And, this was a decision made by my
>     theme users, not me.
>
>     Personally, I don't even check for a "comments are closed" message
>     at all in my reviews.  I consider that a theme developer's choice,
>     even if I don't like the message sitting there on pages.
>
>
>     On 3/1/2011 4:49 PM, Chip Bennett wrote:
>>     Correct. Pages shouldn't display any sort of notice regarding
>>     comments, if comments are closed. Primarily, this is to
>>     facilitate Page-based sites that use WordPress, for which
>>     references to comments on Pages would be undesirable.
>>
>>     Chip
>>
>>     On Tue, Mar 1, 2011 at 4:47 PM, Daniel Tara
>>     <contact at onedesigns.com <mailto:contact at onedesigns.com>> wrote:
>>
>>         None. Static pages must not display any notices when comments
>>         are closed.
>>
>>         Daniel
>>
>>         *From:*theme-reviewers-bounces at lists.wordpress.org
>>         <mailto:theme-reviewers-bounces at lists.wordpress.org>
>>         [mailto:theme-reviewers-bounces at lists.wordpress.org
>>         <mailto:theme-reviewers-bounces at lists.wordpress.org>] *On
>>         Behalf Of *Robert Ambartsumov
>>         *Sent:* Wednesday, March 02, 2011 12:45 AM
>>         *To:* theme-reviewers at lists.wordpress.org
>>         <mailto:theme-reviewers at lists.wordpress.org>
>>         *Subject:* [theme-reviewers] Comments are closed on pages
>>
>>         which of the following can be displayed on pages with closed
>>         comments:
>>
>>         Responses are currently closed, but you can trackback from
>>         your own site.
>>
>>         Comments are closed.
>>
>>         I belive 2nd one cant be displayed, but first one?
>>
>>
>>         _______________________________________________
>>         theme-reviewers mailing list
>>         theme-reviewers at lists.wordpress.org
>>         <mailto:theme-reviewers at lists.wordpress.org>
>>         http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>>
>>     _______________________________________________
>>     theme-reviewers mailing list
>>     theme-reviewers at lists.wordpress.org  <mailto:theme-reviewers at lists.wordpress.org>
>>     http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>     _______________________________________________
>     theme-reviewers mailing list
>     theme-reviewers at lists.wordpress.org
>     <mailto:theme-reviewers at lists.wordpress.org>
>     http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110302/bd081de7/attachment.htm>