[theme-reviewers] Note to theme reviewers about settings in themes
Azizur Rahman
prodevstudio+wordpress at gmail.com
Sun Jun 12 20:45:09 UTC 2011
Hi Otto,
I take this could also apply to plugins!
Kind Regards,
Azizur Rahman
On Sun, Jun 12, 2011 at 9:26 PM, Otto <otto at ottodestruct.com> wrote:
> This is just a note about a rule that I think should be added to the
> theme review process:
>
> - Themes should not do anything to the database merely by virtue of
> being activated.
>
> By that, I mean that having a theme check for a setting, like
> get_option or get_theme_mod and then calling set_option or
> set_theme_mod to set it to some default is wrong.
>
> Both get_option and get_theme_mod accept a second parameter of a
> default setting. If I call get_option('whatever',123) and there is no
> whatever option, then that will return 123.
>
> Use the defaults properly. Don't set them just because they're not there.
>
> -Otto
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110612/7a65036b/attachment.htm>
More information about the theme-reviewers
mailing list