[theme-reviewers] Note to theme reviewers about settings in themes
emil at themeid.com
Sun Jun 12 20:50:46 UTC 2011
Maybe we could also add few references on make.wordpress.org/themes and/or
Theme Review page to:
*Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
emil at themeid.com | http://themeid.com
Make everything as simple as possible, but not simpler. - Albert Einstein
On Sun, Jun 12, 2011 at 3:45 PM, Azizur Rahman <
prodevstudio+wordpress at gmail.com> wrote:
> Hi Otto,
> I take this could also apply to plugins!
> Kind Regards,
> Azizur Rahman
> On Sun, Jun 12, 2011 at 9:26 PM, Otto <otto at ottodestruct.com> wrote:
>> This is just a note about a rule that I think should be added to the
>> theme review process:
>> - Themes should not do anything to the database merely by virtue of
>> being activated.
>> By that, I mean that having a theme check for a setting, like
>> get_option or get_theme_mod and then calling set_option or
>> set_theme_mod to set it to some default is wrong.
>> Both get_option and get_theme_mod accept a second parameter of a
>> default setting. If I call get_option('whatever',123) and there is no
>> whatever option, then that will return 123.
>> Use the defaults properly. Don't set them just because they're not there.
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers