Hi Otto,<br><br>I take this could also apply to plugins!<br><br clear="all">Kind Regards,<br>Azizur Rahman<br><br><br><div class="gmail_quote">On Sun, Jun 12, 2011 at 9:26 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is just a note about a rule that I think should be added to the<br>
theme review process:<br>
<br>
- Themes should not do anything to the database merely by virtue of<br>
being activated.<br>
<br>
By that, I mean that having a theme check for a setting, like<br>
get_option or get_theme_mod and then calling set_option or<br>
set_theme_mod to set it to some default is wrong.<br>
<br>
Both get_option and get_theme_mod accept a second parameter of a<br>
default setting. If I call get_option('whatever',123) and there is no<br>
whatever option, then that will return 123.<br>
<br>
Use the defaults properly. Don't set them just because they're not there.<br>
<font color="#888888"><br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</font></blockquote></div><br><div style="padding:0px;margin-left:0px;margin-top:0px;overflow:hidden;word-wrap:break-word;color:black;font-size:10px;text-align:left;line-height:130%">
</div>
<div style="visibility: hidden; left: -5000px; position: absolute; z-index: 9999; padding: 0px; margin-left: 0px; margin-top: 0px; overflow: hidden; word-wrap: break-word; color: black; font-size: 10px; text-align: left; line-height: 130%;" id="avg_ls_inline_popup">
</div>