[theme-reviewers] Theme Review Process

[Philip M. Hofer (Frumph)]

don't look at me, I do cursory glances like everyone else, I only take my 
time when theme-check and everything else reports pass, then I get thorough.

So basically if it passes theme-check just fail it with the report from 
theme check and move on, write something at the bottom that this is a 
cursory glance and next reviewer might find more, see 
http://make.wordpress.org/themes/about/resources/ for a list of resources 
available for testing your theme.

Something like that







----- Original Message ----- 
From: "Amy Hendrix" <sabreuse at gmail.com>
To: <theme-reviewers at lists.wordpress.org>
Sent: Tuesday, January 11, 2011 8:36 AM
Subject: Re: [theme-reviewers] Theme Review Process


Hi Josh,

Theme Check inspects the code for required classes, deprecated
functions and so on. The Unit Test needs human eyes for whether things
display as they should - so they both need to be done, and keep in
mind that there are other things in the review process (like options
security, or testing that any add-on functionality actually works)
that can't possibly be covered by either of those.

On the other hand, if a ton of required stuff fails on the first pass,
you don't need to go through everything. In that case, DO indicate in
your review that yours is a preliminary review and other reviewers
will be checking for other things in future versions. Some devs take a
review as a checklist, and think that once everything that was
explicitly mentioned is fixed they're automatically done.

(And don't worry about not being a speed demon like Frumph. My first
couple of reviews took forever, and they get a whole lot faster as you
build your own routine.)

Good luck,
Amy

On Tue, Jan 11, 2011 at 10:49 AM, Josh Stauffer <joshstauffer at gmail.com> 
wrote:
> Hello WPTRT,
> I have all three plugins installed (Theme Check, Debogger, and Log Deps) 
> and
> have been checking themes against the Theme Unit Test and Theme Review. 
> I've
> spent about 5 hours total on my first two reviews. Does it usually require
> this much time? I must be doing something wrong. ;-(
>>
>> Takes about 5-15mins if i'm being lazy and theme-check plugin reports a
>> ton of stuff to 1/2 hour for a full check on one including security, when 
>> I
>> first started it was about 45 minutes
>>
>> -Frumph
>
> Is it necessary for me to check the theme against each item on the Theme
> Review or is that what the Theme Check plugin is checking?
> Also, how much effort do you put into a review before you send it back to
> the author. For example, let's say I start reviewing the theme and I find 
> 5
> required items that need to be fixed. Should I stop my review and post my
> comments about the 5 items and reiterate to the theme author that he 
> should
> check the theme guidelines before submitting again?
> I am learning and I am enjoying my time spent thus far. Just looking for
> input on how to become more efficient. ;-)
> Josh Stauffer
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers