[theme-reviewers] theme-reviewers Digest, Vol 9, Issue 16

Michelle Langston michellelangston at gmail.com
Mon Feb 14 16:26:57 UTC 2011


All right, I'll reorganize it and re-submit. Thanks!

Michelle

On Mon, Feb 14, 2011 at 7:00 AM, <
theme-reviewers-request at lists.wordpress.org> wrote:

> Send theme-reviewers mailing list submissions to
>        theme-reviewers at lists.wordpress.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>        http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> or, via email, send a message with subject or body 'help' to
>        theme-reviewers-request at lists.wordpress.org
>
> You can reach the person managing the list at
>        theme-reviewers-owner at lists.wordpress.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of theme-reviewers digest..."
>
>
> Today's Topics:
>
>   1. Re: Theme-Check updates (Edward Caissie)
>   2. Question about a theme I'm submitting (Michelle Langston)
>   3. Re: Question about a theme I'm submitting (furcifer at furcifer.me)
>   4. Re: Question about a theme I'm submitting (Chip Bennett)
>   5. Re: Question about a theme I'm submitting (Otto)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sun, 13 Feb 2011 12:01:44 -0500
> From: Edward Caissie <edward.caissie at gmail.com>
> Subject: Re: [theme-reviewers] Theme-Check updates
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
>        <AANLkTinRns+2dVSfziBon2Zdr7fWy9ByCEzfrUqQTv=T at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Thanks for taking my patch into consideration.
>
>
> Cais.
>
> On Sat, Feb 12, 2011 at 7:37 PM, Simon Prosser <pross at pross.org.uk> wrote:
>
> > Those of you not following git or svn (most probably) here are the major
> > changes for the next release, should be this weekend with 3.1 (?)
> >
> >
> > * More worms detected.
> > * Better 'automated theme' checking.
> > * Results better rendered in trac format.
> > * AuthorURI and ThemeURI auto whitelisted in link checking.
> > * New checks and features now have to be enabled with TC_TEST $var.
> > * Child themes get more support, including version checking with new
> > header tag ( see http://core.trac.wordpress.org/ticket/16395 ).
> > * Other small fixes and bug fixes.
> >
> >
> > --
> > My Blog: http://www.pross.org.uk/
> > Plugins: http://www.pross.org.uk/plugins/
> > Themes : http://wordpress.org/extend/themes/profile/pross
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/f455e98f/attachment-0001.htm
> >
>
> ------------------------------
>
> Message: 2
> Date: Sun, 13 Feb 2011 17:08:16 -0500
> From: Michelle Langston <michellelangston at gmail.com>
> Subject: [theme-reviewers] Question about a theme I'm submitting
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
>        <AANLkTik3YZXLVKck3Op1SyUAk6tbu00Gj6S+aMqnD9yi at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hello, everyone!
>
> I've just submitted a theme framework to the repository. However, the
> submission form gave me a notice to add some classes (image alignment,
> captions, etc) to my CSS file and re-upload. Due to the way my theme is set
> up, the "style.css" file imports styles from a master CSS file in another
> folder. The required classes *are* in the master css file. I'm assuming the
> scanner did not pick it up because it's in a different folder.
>
> My question is, if I received a message from the uploader telling me to add
> classes to the CSS and re-submit, did you receive the theme or do I need to
> submit the theme again?
>
> By the way, the name of my theme is "Citizen Press".
>
> Thank you so much! :)
>
> Michelle
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/6791b6f8/attachment-0001.htm
> >
>
> ------------------------------
>
> Message: 3
> Date: Sun, 13 Feb 2011 22:13:43 -0000
> From: furcifer at furcifer.me
> Subject: Re: [theme-reviewers] Question about a theme I'm submitting
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
>        <8e4c87ea6329b8eaea41043b730f032f.squirrel at projectsnowfire.com>
> Content-Type: text/plain;charset=iso-8859-1
>
> I'm not seeing the theme in the trac, so you may have to add the classes
> to the main file in order for it to upload
>
> > Hello, everyone!
> >
> > I've just submitted a theme framework to the repository. However, the
> > submission form gave me a notice to add some classes (image alignment,
> > captions, etc) to my CSS file and re-upload. Due to the way my theme is
> > set
> > up, the "style.css" file imports styles from a master CSS file in another
> > folder. The required classes *are* in the master css file. I'm assuming
> > the
> > scanner did not pick it up because it's in a different folder.
> >
> > My question is, if I received a message from the uploader telling me to
> > add
> > classes to the CSS and re-submit, did you receive the theme or do I need
> > to
> > submit the theme again?
> >
> > By the way, the name of my theme is "Citizen Press".
> >
> > Thank you so much! :)
> >
> > Michelle
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
>
>
>
>
> ------------------------------
>
> Message: 4
> Date: Sun, 13 Feb 2011 16:18:13 -0600
> From: Chip Bennett <chip at chipbennett.net>
> Subject: Re: [theme-reviewers] Question about a theme I'm submitting
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
>        <AANLkTimEH2dBY6YcXTQOKEreMt7y6C7+jXj7rNeSNJRh at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> It should be in Trac somewhere; that sort of error shouldn't actually be
> blocking upload *at this time*.
>
> Suggestion: add "dummy" class declarations for all required CSS classes,
> and
> add inline documentation indicating the path/file in which the classes are
> actually defined. That way, the Theme won't cause an error to be thrown,
> and
> the reviewer will know where to look for the class definitions.
>
> Chip
>
> On Sun, Feb 13, 2011 at 4:13 PM, <furcifer at furcifer.me> wrote:
>
> > I'm not seeing the theme in the trac, so you may have to add the classes
> > to the main file in order for it to upload
> >
> > > Hello, everyone!
> > >
> > > I've just submitted a theme framework to the repository. However, the
> > > submission form gave me a notice to add some classes (image alignment,
> > > captions, etc) to my CSS file and re-upload. Due to the way my theme is
> > > set
> > > up, the "style.css" file imports styles from a master CSS file in
> another
> > > folder. The required classes *are* in the master css file. I'm assuming
> > > the
> > > scanner did not pick it up because it's in a different folder.
> > >
> > > My question is, if I received a message from the uploader telling me to
> > > add
> > > classes to the CSS and re-submit, did you receive the theme or do I
> need
> > > to
> > > submit the theme again?
> > >
> > > By the way, the name of my theme is "Citizen Press".
> > >
> > > Thank you so much! :)
> > >
> > > Michelle
> > > _______________________________________________
> > > theme-reviewers mailing list
> > > theme-reviewers at lists.wordpress.org
> > > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> > >
> >
> >
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/1bfdb0eb/attachment-0001.htm
> >
>
> ------------------------------
>
> Message: 5
> Date: Sun, 13 Feb 2011 21:56:06 -0600
> From: Otto <otto at ottodestruct.com>
> Subject: Re: [theme-reviewers] Question about a theme I'm submitting
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
>        <AANLkTinOE2WSTFOeFPLgFLVgER-U7-6PN00CkOtnj1zt at mail.gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> On Sun, Feb 13, 2011 at 4:18 PM, Chip Bennett <chip at chipbennett.net>
> wrote:
> > It should be in Trac somewhere; that sort of error shouldn't actually be
> > blocking upload *at this time*.
>
> Actually, the original CSS check (not the one in the theme-check
> check) will indeed block uploads because of that.
>
> > Suggestion: add "dummy" class declarations for all required CSS classes,
> and
> > add inline documentation indicating the path/file in which the classes
> are
> > actually defined. That way, the Theme won't cause an error to be thrown,
> and
> > the reviewer will know where to look for the class definitions.
>
> My suggestion would be to reorganize the theme so as to minimize the
> CSS files you use down to one and one only, if possible. Every time
> you have CSS using import for another CSS file, then you cause the
> browser to make another costly HTTP request. For optimization and
> speed reasons, you should only use one CSS file per media-type, if
> possible.
>
> -Otto
>
>
> ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> End of theme-reviewers Digest, Vol 9, Issue 16
> **********************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110214/2c814344/attachment.htm>


More information about the theme-reviewers mailing list