All right, I'll reorganize it and re-submit. Thanks!<br><br>Michelle<br><br><div class="gmail_quote">On Mon, Feb 14, 2011 at 7:00 AM, <span dir="ltr"><<a href="mailto:theme-reviewers-request@lists.wordpress.org">theme-reviewers-request@lists.wordpress.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Send theme-reviewers mailing list submissions to<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:theme-reviewers-request@lists.wordpress.org">theme-reviewers-request@lists.wordpress.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:theme-reviewers-owner@lists.wordpress.org">theme-reviewers-owner@lists.wordpress.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of theme-reviewers digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: Theme-Check updates (Edward Caissie)<br>
2. Question about a theme I'm submitting (Michelle Langston)<br>
3. Re: Question about a theme I'm submitting (<a href="mailto:furcifer@furcifer.me">furcifer@furcifer.me</a>)<br>
4. Re: Question about a theme I'm submitting (Chip Bennett)<br>
5. Re: Question about a theme I'm submitting (Otto)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Sun, 13 Feb 2011 12:01:44 -0500<br>
From: Edward Caissie <<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>><br>
Subject: Re: [theme-reviewers] Theme-Check updates<br>
To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
Message-ID:<br>
<AANLkTinRns+2dVSfziBon2Zdr7fWy9ByCEzfrUqQTv=<a href="mailto:T@mail.gmail.com">T@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="iso-8859-1"<br>
<br>
Thanks for taking my patch into consideration.<br>
<br>
<br>
Cais.<br>
<br>
On Sat, Feb 12, 2011 at 7:37 PM, Simon Prosser <<a href="mailto:pross@pross.org.uk">pross@pross.org.uk</a>> wrote:<br>
<br>
> Those of you not following git or svn (most probably) here are the major<br>
> changes for the next release, should be this weekend with 3.1 (?)<br>
><br>
><br>
> * More worms detected.<br>
> * Better 'automated theme' checking.<br>
> * Results better rendered in trac format.<br>
> * AuthorURI and ThemeURI auto whitelisted in link checking.<br>
> * New checks and features now have to be enabled with TC_TEST $var.<br>
> * Child themes get more support, including version checking with new<br>
> header tag ( see <a href="http://core.trac.wordpress.org/ticket/16395" target="_blank">http://core.trac.wordpress.org/ticket/16395</a> ).<br>
> * Other small fixes and bug fixes.<br>
><br>
><br>
> --<br>
> My Blog: <a href="http://www.pross.org.uk/" target="_blank">http://www.pross.org.uk/</a><br>
> Plugins: <a href="http://www.pross.org.uk/plugins/" target="_blank">http://www.pross.org.uk/plugins/</a><br>
> Themes : <a href="http://wordpress.org/extend/themes/profile/pross" target="_blank">http://wordpress.org/extend/themes/profile/pross</a><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/f455e98f/attachment-0001.htm" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/f455e98f/attachment-0001.htm</a>><br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Sun, 13 Feb 2011 17:08:16 -0500<br>
From: Michelle Langston <<a href="mailto:michellelangston@gmail.com">michellelangston@gmail.com</a>><br>
Subject: [theme-reviewers] Question about a theme I'm submitting<br>
To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
Message-ID:<br>
<<a href="mailto:AANLkTik3YZXLVKck3Op1SyUAk6tbu00Gj6S%2BaMqnD9yi@mail.gmail.com">AANLkTik3YZXLVKck3Op1SyUAk6tbu00Gj6S+aMqnD9yi@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="iso-8859-1"<br>
<br>
Hello, everyone!<br>
<br>
I've just submitted a theme framework to the repository. However, the<br>
submission form gave me a notice to add some classes (image alignment,<br>
captions, etc) to my CSS file and re-upload. Due to the way my theme is set<br>
up, the "style.css" file imports styles from a master CSS file in another<br>
folder. The required classes *are* in the master css file. I'm assuming the<br>
scanner did not pick it up because it's in a different folder.<br>
<br>
My question is, if I received a message from the uploader telling me to add<br>
classes to the CSS and re-submit, did you receive the theme or do I need to<br>
submit the theme again?<br>
<br>
By the way, the name of my theme is "Citizen Press".<br>
<br>
Thank you so much! :)<br>
<br>
Michelle<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/6791b6f8/attachment-0001.htm" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/6791b6f8/attachment-0001.htm</a>><br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Sun, 13 Feb 2011 22:13:43 -0000<br>
From: <a href="mailto:furcifer@furcifer.me">furcifer@furcifer.me</a><br>
Subject: Re: [theme-reviewers] Question about a theme I'm submitting<br>
To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
Message-ID:<br>
<<a href="mailto:8e4c87ea6329b8eaea41043b730f032f.squirrel@projectsnowfire.com">8e4c87ea6329b8eaea41043b730f032f.squirrel@projectsnowfire.com</a>><br>
Content-Type: text/plain;charset=iso-8859-1<br>
<br>
I'm not seeing the theme in the trac, so you may have to add the classes<br>
to the main file in order for it to upload<br>
<br>
> Hello, everyone!<br>
><br>
> I've just submitted a theme framework to the repository. However, the<br>
> submission form gave me a notice to add some classes (image alignment,<br>
> captions, etc) to my CSS file and re-upload. Due to the way my theme is<br>
> set<br>
> up, the "style.css" file imports styles from a master CSS file in another<br>
> folder. The required classes *are* in the master css file. I'm assuming<br>
> the<br>
> scanner did not pick it up because it's in a different folder.<br>
><br>
> My question is, if I received a message from the uploader telling me to<br>
> add<br>
> classes to the CSS and re-submit, did you receive the theme or do I need<br>
> to<br>
> submit the theme again?<br>
><br>
> By the way, the name of my theme is "Citizen Press".<br>
><br>
> Thank you so much! :)<br>
><br>
> Michelle<br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 4<br>
Date: Sun, 13 Feb 2011 16:18:13 -0600<br>
From: Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>><br>
Subject: Re: [theme-reviewers] Question about a theme I'm submitting<br>
To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
Message-ID:<br>
<<a href="mailto:AANLkTimEH2dBY6YcXTQOKEreMt7y6C7%2BjXj7rNeSNJRh@mail.gmail.com">AANLkTimEH2dBY6YcXTQOKEreMt7y6C7+jXj7rNeSNJRh@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="iso-8859-1"<br>
<br>
It should be in Trac somewhere; that sort of error shouldn't actually be<br>
blocking upload *at this time*.<br>
<br>
Suggestion: add "dummy" class declarations for all required CSS classes, and<br>
add inline documentation indicating the path/file in which the classes are<br>
actually defined. That way, the Theme won't cause an error to be thrown, and<br>
the reviewer will know where to look for the class definitions.<br>
<br>
Chip<br>
<br>
On Sun, Feb 13, 2011 at 4:13 PM, <<a href="mailto:furcifer@furcifer.me">furcifer@furcifer.me</a>> wrote:<br>
<br>
> I'm not seeing the theme in the trac, so you may have to add the classes<br>
> to the main file in order for it to upload<br>
><br>
> > Hello, everyone!<br>
> ><br>
> > I've just submitted a theme framework to the repository. However, the<br>
> > submission form gave me a notice to add some classes (image alignment,<br>
> > captions, etc) to my CSS file and re-upload. Due to the way my theme is<br>
> > set<br>
> > up, the "style.css" file imports styles from a master CSS file in another<br>
> > folder. The required classes *are* in the master css file. I'm assuming<br>
> > the<br>
> > scanner did not pick it up because it's in a different folder.<br>
> ><br>
> > My question is, if I received a message from the uploader telling me to<br>
> > add<br>
> > classes to the CSS and re-submit, did you receive the theme or do I need<br>
> > to<br>
> > submit the theme again?<br>
> ><br>
> > By the way, the name of my theme is "Citizen Press".<br>
> ><br>
> > Thank you so much! :)<br>
> ><br>
> > Michelle<br>
> > _______________________________________________<br>
> > theme-reviewers mailing list<br>
> > <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> > <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
> ><br>
><br>
><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/1bfdb0eb/attachment-0001.htm" target="_blank">http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110213/1bfdb0eb/attachment-0001.htm</a>><br>
<br>
------------------------------<br>
<br>
Message: 5<br>
Date: Sun, 13 Feb 2011 21:56:06 -0600<br>
From: Otto <<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>><br>
Subject: Re: [theme-reviewers] Question about a theme I'm submitting<br>
To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
Message-ID:<br>
<<a href="mailto:AANLkTinOE2WSTFOeFPLgFLVgER-U7-6PN00CkOtnj1zt@mail.gmail.com">AANLkTinOE2WSTFOeFPLgFLVgER-U7-6PN00CkOtnj1zt@mail.gmail.com</a>><br>
Content-Type: text/plain; charset=ISO-8859-1<br>
<br>
On Sun, Feb 13, 2011 at 4:18 PM, Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>> wrote:<br>
> It should be in Trac somewhere; that sort of error shouldn't actually be<br>
> blocking upload *at this time*.<br>
<br>
Actually, the original CSS check (not the one in the theme-check<br>
check) will indeed block uploads because of that.<br>
<br>
> Suggestion: add "dummy" class declarations for all required CSS classes, and<br>
> add inline documentation indicating the path/file in which the classes are<br>
> actually defined. That way, the Theme won't cause an error to be thrown, and<br>
> the reviewer will know where to look for the class definitions.<br>
<br>
My suggestion would be to reorganize the theme so as to minimize the<br>
CSS files you use down to one and one only, if possible. Every time<br>
you have CSS using import for another CSS file, then you cause the<br>
browser to make another costly HTTP request. For optimization and<br>
speed reasons, you should only use one CSS file per media-type, if<br>
possible.<br>
<br>
-Otto<br>
<br>
<br>
------------------------------<br>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
<br>
End of theme-reviewers Digest, Vol 9, Issue 16<br>
**********************************************<br>
</blockquote></div><br>