[theme-reviewers] Theme Uploader and CSS Classes

[Chip Bennett]

That wasn't my point.

I'm not talking about the *Guidelines*, I'm talking about the *Uploader*.

Chip

On Fri, Sep 24, 2010 at 2:43 PM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:

>  The aligncenter alignleft and alignright classes have been there from the
> onset, they're automatically inserted into things from the core and not
> including them would drastically remove functionality.
>
>
>
> ----- Original Message -----
> *From:* Chip Bennett <chip at chipbennett.net>
> *To:* theme-reviewers at lists.wordpress.org
> *Sent:* Friday, September 24, 2010 12:40 PM
> *Subject:* Re: [theme-reviewers] Theme Uploader and CSS Classes
>
> Also, I really think the uploader should output ALL failing criteria,
> rather than stopping at the first one.
>
> How frustrating it must be, to have to fix a Theme five or six times,
> re-package it, and re-attempt to upload it. No wonder the Theme developers
> get to us already frustrated!
>
> Otto, can this be fixed? Can you set the upload script to complete ALL of
> its checks, and then output the results, rather than stopping at the first
> failed criterion?
>
> Chip
>
> On Fri, Sep 24, 2010 at 2:37 PM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> I think this is a bit of a fail: the uploader fails if it does not find
>> the alignment classes in style.css.
>>
>> I understand the need to ensure that Themes include alignment classes, but
>> this is part of the Review Guidelines. The uploader fails if it does not
>> find these classes in style.css - but fails to check any other CSS file
>> (that might, e.g. be @import included) to see if one of them includes the
>> alignment classes.
>>
>> The easy fix, of course, is to add the required classes to style.css, and
>> then override them later. But I think this is perhaps something that
>> shouldn't fail the upload process.
>>
>> Thoughts?
>>
>> Chip
>>
>
>  ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100924/d0f69c8e/attachment.htm>