[theme-reviewers] Post formats
edward.caissie at gmail.com
Fri Nov 5 22:18:46 UTC 2010
I agree that post_thumbnail() for the most part should be handling image
thumbnails, but as you noted there are exceptions which would preclude
TimThumb from being prohibited. The basis I am working from is if the code
could be caught and stopped by the upload script in a perfect world then in
our imperfect world it would be a required item. Since there are exceptions
to the rule when TimThumb could be viable then it should be noted as such.
I would suggest, we put it forward along the lines of: if TimThumb is being
used within a theme then it should be explained why it is required over the
core functionality of post_thumbnail(). No explanation, no approval; and,
of course, the explanation has to be sensible. The explanation has to be
somewhere reasonable as well, which brings another item: the 'readme.txt'
file inclusion. Another item for 3.1 ... and likely another thread for
clarity of discussion.
On Fri, Nov 5, 2010 at 4:11 PM, Chip Bennett <chip at chipbennett.net> wrote:
> When we asked the question the first time, the only response that we got,
> with respect to functionality that could not be handled by core WordPress
> Post Thumbnail functionality, was creating Thumbnails of external images. I
> think that this use case is enough of a niche that it is an exception, and
> one that should not dictate the rule.
> All other functionality within TimThumb can be implemented using core
> WordPress Post Thumbnail functionality, as far as I can tell.
> On Fri, Nov 5, 2010 at 2:47 PM, Edward Caissie <edward.caissie at gmail.com>wrote:
>> On Fri, Nov 5, 2010 at 2:39 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>> 3) Use of TimThumb prohibited (*required* not to use, even for backward
>>> compatibility). If we go this route, I will volunteer to put together a
>>> tutorial for how to migrate TimThumb-generated images using custom fields
>>> over to the WordPress media manager.
>> There are uses for TimThumb other than backward compatibility in some
>> themes. To the best of my knowledge they are not in the repository yet, but
>> they are being considered. I would temper that point with "not to be used
>> for direct backward-compatibility of post_thumbnail" or something to that
>> TimThumb (current and security-safe) versions may be the most optimal way
>> of integrating other third party functionality. Something to consider before
>> making it "prohibited".
>> I think a tutorial on "how to migrate TimThumb-generated images using
>> custom fields over to the WordPress media manager." would also be very
>> useful to have.
>> I still need to read through more items, but the TimThumb issue strikes me
>> as a sensitive subject. I want to get it right the first time it goes into
>> the guidelines rather that having multiple re-writes on it.
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the theme-reviewers