I agree that post_thumbnail() for the most part should be handling image thumbnails, but as you noted there are exceptions which would preclude TimThumb from being prohibited. The basis I am working from is if the code could be caught and stopped by the upload script in a perfect world then in our imperfect world it would be a required item. Since there are exceptions to the rule when TimThumb could be viable then it should be noted as such.<br>
<br>I would suggest, we put it forward along the lines of: if TimThumb is being used within a theme then it should be explained why it is required over the core functionality of post_thumbnail(). No explanation, no approval; and, of course, the explanation has to be sensible. The explanation has to be somewhere reasonable as well, which brings another item: the 'readme.txt' file inclusion. Another item for 3.1 ... and likely another thread for clarity of discussion.<br>
<br><br>Cais.<br><br><div class="gmail_quote">On Fri, Nov 5, 2010 at 4:11 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
When we asked the question the first time, the only response that we got, with respect to functionality that could not be handled by core WordPress Post Thumbnail functionality, was creating Thumbnails of external images. I think that this use case is enough of a niche that it is an exception, and one that should not dictate the rule.<div>
<br></div><div>All other functionality within TimThumb can be implemented using core WordPress Post Thumbnail functionality, as far as I can tell.</div><div><br></div><div><font color="#888888">Chip<br><br></font><div class="gmail_quote">
<div><div></div><div class="h5">On Fri, Nov 5, 2010 at 2:47 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div class="h5"><div><div class="gmail_quote">On Fri, Nov 5, 2010 at 2:39 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
3) Use of TimThumb prohibited (*required* not to use, even for backward compatibility). If we go this route, I will volunteer to put together a tutorial for how to migrate TimThumb-generated images using custom fields over to the WordPress media manager.</blockquote>
</div><br></div>There are uses for TimThumb other than backward compatibility in some themes. To the best of my knowledge they are not in the repository yet, but they are being considered. I would temper that point with "not to be used for direct backward-compatibility of post_thumbnail" or something to that effect.<br>
<br>TimThumb (current and security-safe) versions may be the most optimal way of integrating other third party functionality. Something to consider before making it "prohibited".<br><br>I think a tutorial on "how to migrate TimThumb-generated images using custom fields over to the
WordPress media manager." would also be very useful to have.<br><br>I still need to read through more items, but the TimThumb issue strikes me as a sensitive subject. I want to get it right the first time it goes into the guidelines rather that having multiple re-writes on it.<br>
<br><br>Cais.<br>
<br></div></div><div class="im">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>